Skip to content

Conversation

devin-ai-integration[bot]
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Jan 29, 2025

Adds Python 3.12 support to the Python CDK by:

  • Updating Python version constraint to include 3.12
  • Adding Python 3.12 to the CI test matrix

This PR builds on, and should be merged after:

Link to Devin run: https://app.devin.ai/sessions/6d33a0710ff94c828eb8d316f04b8e24

devin-ai-integration bot and others added 30 commits January 23, 2025 18:41
- Introduces AirbyteDateTime class for consistent ISO8601/RFC3339 formatting
- Adds helper functions for datetime operations
- Includes comprehensive test coverage
- Prepares for Pendulum removal

Co-Authored-By: Aaron <AJ> Steers <[email protected]>
- Remove pendulum imports
- Replace pendulum.now() with datetime_helpers.now()
- Replace pendulum.parse() with datetime_helpers.parse()
- Replace pendulum.DateTime type hints with AirbyteDateTime
- Update time arithmetic to use standard datetime operations

Co-Authored-By: Aaron <AJ> Steers <[email protected]>
Resolving dependencies... changes
…operator overloading

Co-Authored-By: Aaron <AJ> Steers <[email protected]>
Copy link
Contributor Author

🤖 Devin AI Engineer

Original prompt from Aaron:

@Devin - Create a PR targeting this one (<https://github.com/airbytehq/airbyte-python-cdk/pull/258>)  and expand our CI test matrix along with the Python version constraint in pyproject.toml, adding support for Python 3.12. I want to see if we have other failures to address or if the Pendulum removal is sufficient.

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add "(aside)" to your comment to have me ignore it.
  • Look at CI failures and help fix them

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@github-actions github-actions bot added the ci label Jan 29, 2025
@devin-ai-integration devin-ai-integration bot force-pushed the devin/1738112382-add-python-312-support branch 3 times, most recently from 3bba9bb to 4d1ae74 Compare January 29, 2025 02:08
@devin-ai-integration devin-ai-integration bot force-pushed the devin/1738112382-add-python-312-support branch from 4d1ae74 to 25e4590 Compare January 29, 2025 02:32
Copy link
Contributor Author

Devin is currently unreachable - the session may have died.

@aaronsteers
Copy link
Contributor

aaronsteers commented Jan 29, 2025

/poetry-lock

Poetry-Lock Job Info

This job attempts to re-lock dependencies using poetry lock command. If any changes
are made, those changes will be automatically committed and pushed back to the PR.

Note: This job can only be run by maintainers. On PRs from forks, this command requires
that the PR author has enabled the Allow edits from maintainers option.

poetry lock job started... Check job output.

poetry lock applied successfully.

Base automatically changed from devin/1737657683-remove-pendulum to main January 29, 2025 04:36
@aaronsteers
Copy link
Contributor

aaronsteers commented Jan 29, 2025

/poetry-lock

Poetry-Lock Job Info

This job attempts to re-lock dependencies using poetry lock command. If any changes
are made, those changes will be automatically committed and pushed back to the PR.

Note: This job can only be run by maintainers. On PRs from forks, this command requires
that the PR author has enabled the Allow edits from maintainers option.

poetry lock job started... Check job output.

poetry lock applied successfully.

@aaronsteers aaronsteers enabled auto-merge (squash) January 29, 2025 04:40
@aaronsteers aaronsteers disabled auto-merge January 29, 2025 05:04
@aaronsteers aaronsteers enabled auto-merge (squash) January 29, 2025 05:04
@aaronsteers aaronsteers merged commit 3af96dc into main Jan 29, 2025
20 of 24 checks passed
@aaronsteers aaronsteers deleted the devin/1738112382-add-python-312-support branch January 29, 2025 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant