Skip to content

hdl._ast: Make AST nodes immutable. #1165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

wanda-phi
Copy link
Member

Fixes #1067.

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.72%. Comparing base (c6bc9b4) to head (1032a18).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1165      +/-   ##
==========================================
+ Coverage   87.61%   87.72%   +0.10%     
==========================================
  Files          43       43              
  Lines        8695     8787      +92     
  Branches     2058     2088      +30     
==========================================
+ Hits         7618     7708      +90     
  Misses        887      887              
- Partials      190      192       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@whitequark whitequark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@whitequark whitequark added this pull request to the merge queue Feb 29, 2024
Merged via the queue into amaranth-lang:main with commit 2bf1b4d Feb 29, 2024
@wanda-phi wanda-phi deleted the ast-immutable branch February 29, 2024 19:08
@whitequark whitequark added this to the 0.5 milestone Mar 19, 2024
wanda-phi added a commit to wanda-phi/amaranth that referenced this pull request Mar 25, 2024
github-merge-queue bot pushed a commit that referenced this pull request Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Make AST nodes immutable
2 participants