Skip to content

hdl._ast: fix _value_repr computation. #1237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 25, 2024
Merged

hdl._ast: fix _value_repr computation. #1237

merged 1 commit into from
Mar 25, 2024

Conversation

wanda-phi
Copy link
Member

Fixes fallout from #1165.

@wanda-phi wanda-phi requested a review from whitequark as a code owner March 25, 2024 13:42
@wanda-phi wanda-phi mentioned this pull request Mar 25, 2024
Closed
@codecov Codecov
Copy link

codecov bot commented Mar 25, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 92.30769% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 89.85%. Comparing base (11f7b88) to head (756f349).

Files Patch % Lines
amaranth/hdl/_repr.py 87.50% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1237      +/-   ##
==========================================
- Coverage   89.85%   89.85%   -0.01%     
==========================================
  Files          43       43              
  Lines        9957     9962       +5     
  Branches     2404     2404              
==========================================
+ Hits         8947     8951       +4     
- Misses        817      818       +1     
  Partials      193      193

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

whitequark
whitequark approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@whitequark whitequark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@whitequark whitequark added this pull request to the merge queue Mar 25, 2024
Merged via the queue into amaranth-lang:main with commit efcd9a4 Mar 25, 2024
@wanda-phi wanda-phi deleted the repr-fix branch March 25, 2024 14:23
@whitequark whitequark added this to the 0.5 milestone Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whitequark whitequark whitequark approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
0.5
Development

Successfully merging this pull request may close these issues.
2 participants
@wanda-phi @whitequark