Skip to content

build.res: give a more specific error for add_clock_constraint(ClockSignal) #1288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 7, 2024
Merged

build.res: give a more specific error for add_clock_constraint(ClockSignal) #1288

merged 1 commit into from
Apr 7, 2024

Conversation

wanda-phi
Copy link
Member

Fixes #542.

@wanda-phi wanda-phi requested a review from whitequark as a code owner April 6, 2024 11:16
@wanda-phi wanda-phi force-pushed the clocksignal-constraint branch from 72a76c3 to 183496e Compare April 6, 2024 13:20
@codecov Codecov
Copy link

codecov bot commented Apr 6, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 90.54%. Comparing base (7936b87) to head (183496e).

Files Patch % Lines
amaranth/build/res.py 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1288      +/-   ##
==========================================
- Coverage   90.56%   90.54%   -0.02%     
==========================================
  Files          44       44              
  Lines       10642    10644       +2     
  Branches     2593     2594       +1     
==========================================
  Hits         9638     9638              
- Misses        818      819       +1     
- Partials      186      187       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

whitequark
whitequark reviewed Apr 7, 2024
View reviewed changes
@wanda-phi wanda-phi force-pushed the clocksignal-constraint branch from 183496e to 1164ae0 Compare April 7, 2024 09:48
@wanda-phi wanda-phi force-pushed the clocksignal-constraint branch from 1164ae0 to bdd0ebf Compare April 7, 2024 09:48
whitequark
whitequark approved these changes Apr 7, 2024
View reviewed changes
Copy link
Member

@whitequark whitequark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@whitequark whitequark enabled auto-merge April 7, 2024 09:50
@whitequark whitequark added this pull request to the merge queue Apr 7, 2024
@whitequark whitequark added this to the 0.5 milestone Apr 7, 2024
Merged via the queue into amaranth-lang:main with commit 38ad357 Apr 7, 2024
19 checks passed
@wanda-phi wanda-phi deleted the clocksignal-constraint branch April 7, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whitequark whitequark whitequark approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
0.5
Development

Successfully merging this pull request may close these issues.

Using ClockSignal in platform.add_clock_constraint
2 participants
@wanda-phi @whitequark