-
Notifications
You must be signed in to change notification settings - Fork 177
Reland the Nav3 Migration of Results Screen #120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @srikrishnasakunia, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request refines the image display logic within the ImageRenderer.kt
file by changing the specific Jetpack Compose UI component used for rendering images. The primary goal is to ensure images are displayed correctly and efficiently by leveraging a different composable and adjusting the data source accordingly.
Highlights
- Image Rendering Component: Switched from the
AsyncImage
composable (likely from the Coil library) to the standardImage
composable for displaying images within theImageResult
function. - Image Data Source: Updated the image data source from
imageUri
toimageBitmap
when rendering the image, ensuring compatibility with theImage
composable by converting it toImageBitmap
.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request switches back to using Image
instead of AsyncImage
in ImageRenderer.kt
for displaying images. The change involves modifying the condition to check for imageBitmap
instead of imageUri
and using Image
composable with bitmap
parameter. I have identified one issue related to checking for nullability before accessing the asImageBitmap()
method.
} else if (exportImageCanvas.imageUri != null) { | ||
AsyncImage( | ||
model = exportImageCanvas.imageUri, | ||
} else if (exportImageCanvas.imageBitmap != null) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
high: It's crucial to ensure that exportImageCanvas.imageBitmap
is not null before accessing asImageBitmap()
to prevent a potential NullPointerException
. Add a null check to ensure the app doesn't crash if imageBitmap
is null.
} else if (exportImageCanvas.imageBitmap != null) {
exportImageCanvas.imageBitmap?.let {
Image(
bitmap = it.asImageBitmap(),
modifier = Modifier
.fillMaxSize(),
contentScale = ContentScale.Crop,
contentDescription = null,
)
}
…vigation.kt using Nav3 instead of driving them from CreationScreen.kt
# Conflicts: # feature/creation/src/test/kotlin/com/android/developers/androidify/creation/CreationViewModelTest.kt
feature/results/src/main/java/com/android/developers/androidify/results/ResultsScreen.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't comment on the image generation aspects as I don't know how any of that works - I'll leave that for @riggaroo :)
The watch face aspects appear to work and tests pass, so looks good to me.
feature/results/src/main/java/com/android/developers/androidify/customize/CustomizeState.kt
Outdated
Show resolved
Hide resolved
feature/results/src/main/java/com/android/developers/androidify/customize/ImageRenderer.kt
Outdated
Show resolved
Hide resolved
feature/results/src/main/java/com/android/developers/androidify/customize/Utils.kt
Show resolved
Hide resolved
feature/results/src/main/java/com/android/developers/androidify/results/BotResultCard.kt
Show resolved
Hide resolved
...esults/src/main/java/com/android/developers/androidify/customize/CustomizeExportViewModel.kt
Show resolved
Hide resolved
…kt and removed imageUri as it wasn't required anymore.
…kt and removed imageUri as it wasn't required anymore.
...esults/src/test/kotlin/com/android/developers/androidify/customize/CustomizeViewModelTest.kt
Outdated
Show resolved
Hide resolved
…reenImp # Conflicts: # feature/creation/src/main/java/com/android/developers/androidify/creation/CreationViewModel.kt # feature/creation/src/test/kotlin/com/android/developers/androidify/creation/CreationViewModelTest.kt # feature/results/src/main/java/com/android/developers/androidify/customize/CustomizeExportViewModel.kt
WhatsApp.Video.2025-09-11.at.10.42.14.AM.mp4