This repository was archived by the owner on May 29, 2019. It is now read-only.
feat(popover): support template url for partial #3409
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jbruni Are you able to add some tests around this please? |
| .directive( 'popoverTemplatePopup', [ function () { | ||
| return { | ||
| restrict: 'EA', | ||
| replace: true, |
There was a problem hiding this comment.
replace is deprecated - https://github.com/angular/angular.js/blob/master/src/ng/compile.js#L270
There was a problem hiding this comment.
I'm faithfully following what already is in place:
https://github.com/angular-ui/bootstrap/blob/master/src/popover/popover.js#L11
|
Happy for people to make a comparison between this and #1848 . |
|
@karianna - I'm trying to learn how to make tests in my little free time... already made my first steps... hopefully I can have something as soon as possible. |
|
NP: We're happy to wait - there's lots of PRs we're still looking at. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated old solution with improvements:
popover-templateattribute. The template can change at any time.popover-templateis used.)Code in action at http://codepen.io/anon/pen/XJodJr
How to use:
popover-templateattribute