docs(@angular/cli): add scss intructions for include-font-awesome story #10911

chris-milliano · 2018-05-18T03:21:21Z

No description provided.

clydin · 2018-05-18T15:14:47Z

docs/documentation/stories/include-font-awesome.md

+  }
+}
+```
+


There's really two options for SASS. The most common and probably recommended is the above. If there is a need to modify any of the font-awesome sass variables (are there any besides the path?) then the second form below (or a variation) would be used.

Could you section off the two and add a note about the second only being useful in special/advanced cases or similar language?

To clarify, it seems you saying the way I have separated out CSS from SASS (SCSS) is acceptable, but there is a second option on SASS use case I need to elaborate on?

Or are you saying that I should not have separated them, but rather made notes on their differences?

The _variables.scss and import in the section below is not necessary if using the section you added. They should really be separated out. The first that you added is generally the preferred and cleaner unless more fine-grained control is needed with the font-awesome variables.

@clydin I think I am following, I made the minor text separation update.

Thanks. Sorry for the delay in response. The changes look good. Can you rebase and we can get this in.

Awesome!

@clydin I have never rebased before so I followed contributing.md and ran:

git rebase master -i

Which returned Successfully rebased and updated refs/heads/docs-10861.

Then I ran:

git push -f

Which returned Everything up-to-date

But I am not seeing any sort of changes to my code base or PR. Is there another step?

Ensure you have an upstream remote configured: https://help.github.com/articles/configuring-a-remote-for-a-fork/

Sync your master with upstream: https://help.github.com/articles/syncing-a-fork/

Then rebase your branch with your master

@clydin I am not sure if I was successful or did something wrong. Should I be seeing every commit since my fork like below?

no, you should be seeing them. I'm not really sure what happened. Sorry about this but I think it might be best to start over, if possible.

…code Instead of process.exit() which is a bit premature

Its being deprecated in Node 10.4. The replacements are available in Node 8 so its all good.

Update documentation for the hmr story to show proper configurations in angular.json and src/tsconfig.app.json. Closes angular#11028, angular#10668, angular#10663

Fixes angular#8515

We moved the repo from angular-buch to angular-schule

Workaround for webpack/webpack#7499

This change helps to keep the behaviour of build/serve/test consistent by using the same import semantics in all of them.

… from using FA with custom SCSS vars

The changelog function makes a promise but doesn't return it, causing a race condition between the process exiting and the promise finishing. On a repository with bigger git history the promise took longer to execute and the process exited first.

When not specified the `commonjs` will be used which will cause erros when consuming the library `Module not found: Error: Can't resolve ' commonjs-proxy:../file` ng-packagr/ng-packagr#944 Closes angular#11255

Closes: angular#11258

The `options` arguments is not used in the function. This causes the TypeScript compilation to fail. fixes angular#11916

Fixes angular#10963

`fs` is unable to read the normalized paths from `@angular-devkit/core` on `windows` as the disk drive is replaced from `c:/` to `/c/` Closes angular#11928

Fixes angular#11683

@tomastrajan

Closes angular#8772 Fixes angular#6888 Special thanks to @tomastrajan for original PR.

Fixes angular#11543 Fixes angular#11942

Fixes angular#11663

googlebot · 2018-08-21T05:51:57Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

hansl · 2018-09-25T19:44:23Z

Closing this PR as it's unmaintained, has too many unrelated commits (bad rebase?) and cannot merge cleanly. The documentation will go into angular.io soon anyway and the wiki files should be frozen right now.

angular-automatic-lock-bot · 2019-09-12T15:40:55Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

googlebot added the cla: yes label May 18, 2018

chris-milliano mentioned this pull request May 18, 2018

stories include font awesome - Can't resolve variables #10861

Closed

clydin reviewed May 18, 2018

View reviewed changes

alexeagle and others added 27 commits June 8, 2018 14:33

build: fixes for google3 build

938a236

ci: add support for async scripts

8e29419

ci: test script is async

af33321

ci: validate is really async and validate-commits should return error…

47892d2

…code Instead of process.exit() which is a bit premature

ci: update licenses and use promises since license is async

88875c8

feat(angular_devkit): stop blocking karma after compilation error

a11dddf

refactor: remove usage of Buffer constructor

4ba67ee

Its being deprecated in Node 10.4. The replacements are available in Node 8 so its all good.

docs: update hmr documentation

ff2bd3e

Update documentation for the hmr story to show proper configurations in angular.json and src/tsconfig.app.json. Closes angular#11028, angular#10668, angular#10663

feat(@schematics/update): support npm auth bearer tokens

7309c91

fix: typo fix for error logging

dd39597

test: update tslint-no-circular-imports

e4b13ba

refactor(@angular/pwa): minor refactorings to make code cleaner

5452902

refactor(@schematics/angular): minor refactorings

a307f5e

fix(@schematics/angular): allow ServiceWorker to work with baseHref

1405f53

Fixes angular#8515

style(@schematics/angular): minor improvements in ngsw-config.json

8ce5ef4

docs: Add command for angular-cli-ghpages and change repo URL

1f00a36

We moved the repo from angular-buch to angular-schule

feat(@angular-devkit/build-angular): revert to webpack 4.9.2

1ac2270

Workaround for webpack/webpack#7499

feat(@schematics/angular): use es2015 modules overall

b8cecbb

This change helps to keep the behaviour of build/serve/test consistent by using the same import semantics in all of them.

doc(@angular/cli): Split instructions for using FA with standard SCSS…

bc43a13

… from using FA with custom SCSS vars

fix(@schematics/angular): add module option in library tsconfig

76f46bc

When not specified the `commonjs` will be used which will cause erros when consuming the library `Module not found: Error: Can't resolve ' commonjs-proxy:../file` ng-packagr/ng-packagr#944 Closes angular#11255

fix(@schematics/angular): add baseUrl in root tsconfig when migrating

e6b59e4

Closes: angular#11258

fix(@schematics/angular): add module in root tsconfig when migrating

dad2de9

fix(@angular-devkit/build_angular): use webpack 4 hooks for karma plugin

0126721

fix(@schematics/update): ensure auth config options are typed properly

fbdc27d

docs: add reference to vendor-source-map flag

bb21592

fix(@angular-devkit/core): detect ambiguous projects with path discover

c638af2

clydin and others added 20 commits August 15, 2018 15:59

ci: use latest npm 6.x for E2E tests (angular#11898)

ec3fa80

Release 6.2.0-beta.3

21d87e9

docs: add some missing release bits (angular#11921)

53684fe

ci: add SHAs of invalid messages to blacklist

744cfa4

ci: fix pre-push hook

3d80aa8

fix(@schematics/schematics): prefix unused argument with underscore

068dfa4

The `options` arguments is not used in the function. This causes the TypeScript compilation to fail. fixes angular#11916

feat(@schematics/angular): update karma to v3

e66394f

Fixes angular#10963

feat(@angular-devkit/build-angular): update karma to v3

eb87002

build: re-add name and version field so npm link works

a5e0c72

build: add license whitelist to allow license validation

15b9ccb

feat(@angular-devkit/core): add json namespace export

055a157

refactor: move isJsonObject to json namespace

f9ad0e2

fix(@angular/cli): command runner is not working on windows

b759ebd

`fs` is unable to read the normalized paths from `@angular-devkit/core` on `windows` as the disk drive is replaced from `c:/` to `/c/` Closes angular#11928

fix(@angular-devkit/schematics): improve tree type checking

07c829d

Fixes angular#11683

feat(@angular/cli): add flags to the process title

9595190

Closes angular#8772 Fixes angular#6888 Special thanks to @tomastrajan for original PR.

ci: use select e2e tests instead of large unit tests with AppVeyor

3034bef

ci: improve yarn caching on AppVeyor

682cae1

fix(@angular/pwa): properly write closing body tag when modifying index

ad84bb1

Fixes angular#11543 Fixes angular#11942

fix(@angular/pwa): support ng add with CLI 6.0.x

b4a3076

Fixes angular#11663

docs(@angular-cli): fix rebase conflict

8544909

googlebot added cla: no and removed cla: yes labels Aug 21, 2018

alan-agius4 closed this Aug 23, 2018

clydin reopened this Aug 23, 2018

clydin added the state: WIP label Aug 23, 2018

hansl closed this Sep 25, 2018

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

docs(@angular/cli): add scss intructions for include-font-awesome story #10911

docs(@angular/cli): add scss intructions for include-font-awesome story #10911

chris-milliano commented May 18, 2018

clydin May 18, 2018

chris-milliano May 22, 2018

clydin May 30, 2018

chris-milliano Jun 14, 2018 •

edited

Loading

clydin Aug 14, 2018

chris-milliano Aug 15, 2018

clydin Aug 15, 2018

chris-milliano Aug 21, 2018

clydin Aug 22, 2018

googlebot commented Aug 21, 2018

hansl commented Sep 25, 2018

angular-automatic-lock-bot bot commented Sep 12, 2019

docs(@angular/cli): add scss intructions for include-font-awesome story #10911

docs(@angular/cli): add scss intructions for include-font-awesome story #10911

Conversation

chris-milliano commented May 18, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chris-milliano Jun 14, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

googlebot commented Aug 21, 2018

hansl commented Sep 25, 2018

angular-automatic-lock-bot bot commented Sep 12, 2019

chris-milliano Jun 14, 2018 •

edited

Loading