Skip to content

feat(@ngtools/webpack): add AngularCompilerPlugin #7512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

feat(@ngtools/webpack): add AngularCompilerPlugin #7512

wants to merge 2 commits into from

Conversation

filipesilva
Copy link
Contributor

No description provided.

@filipesilva filipesilva requested a review from hansl as a code owner August 25, 2017 21:20
@filipesilva filipesilva force-pushed the aot-watch branch 5 times, most recently from 5f67849 to 2adf521 Compare August 28, 2017 16:40
hansl
hansl suggested changes Aug 28, 2017
View reviewed changes
package.json Outdated
@@ -90,7 +90,7 @@
"style-loader": "^0.13.1",
"stylus": "^0.54.5",
"stylus-loader": "^3.0.1",
"typescript": "~2.4.2",
"typescript": "^2.3.2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want to unlock typescript. There's no guarantee our stuff will work with TS 2.6

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was needed to test a linked AIO since it isn't ts 2.4 ready. Will remove before PR is done.

@filipesilva filipesilva force-pushed the aot-watch branch 19 times, most recently from 1afe042 to 31bcf9b Compare August 30, 2017 20:06
@filipesilva filipesilva force-pushed the aot-watch branch 7 times, most recently from bf9f231 to 2475383 Compare September 4, 2017 16:15
hansl
hansl reviewed Sep 12, 2017
View reviewed changes
packages/@ngtools/webpack/src/angular_compiler_plugin.ts Outdated
}

enum Platform {
browser,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please capitalize enum names.

@hansl
Copy link
Contributor

hansl commented Sep 12, 2017

Only other comment would be to have this on by default when the user uses AOT and Angular 5.

@hansl
Copy link
Contributor

hansl commented Sep 12, 2017

I would see 3 paths here:

  1. ng2/4, use the AotPlugin as before (backward compatible)
  2. ng5 + JIT, use the AotPlugin FOR NOW, have a separate PR for adding emit+transform support
  3. ng5 + AOT, use the AngularCompilerPlugin.

1 and 3 should be part of this PR, while 2 should be a separate PR.

@filipesilva filipesilva force-pushed the aot-watch branch 3 times, most recently from 898d5d8 to 3270909 Compare September 13, 2017 10:14
@filipesilva filipesilva mentioned this pull request Sep 13, 2017
Merged
hansl
hansl suggested changes Sep 13, 2017
View reviewed changes
packages/@angular/cli/commands/build.ts
@@ -176,6 +177,13 @@ export const baseBuildCommandOptions: any = [
aliases: ['nc'],
description: 'Use file name for lazy loaded chunks.',
default: buildConfigDefaults['namedChunks']
},
{
name: 'experimental-angular-compiler',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we were getting rid of this by using a version check.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, that will happen once we have JIT support.

packages/@ngtools/webpack/src/angular_compiler_plugin.ts
}

enum PLATFORM {
browser,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capitalize enum values.

.appveyor.yml
@@ -18,4 +18,4 @@ test_script:
build: off

cache:
- node_modules
- node_modules -> package-lock.json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does the package-lock.json means here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's how that cache gets invalidated, I was having trouble with this PR in appveyour and had to invalidate it properly.

packages/@ngtools/webpack/src/transformers/replace_bootstrap.ts
@@ -0,0 +1,114 @@
import * as ts from 'typescript';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unittests for this file? It's quite sensitive code that I'd like to avoid regressions.

@hansl hansl mentioned this pull request Sep 13, 2017
Merged
@hansl hansl closed this in #7685 Sep 13, 2017
@filipesilva filipesilva deleted the aot-watch branch September 14, 2017 11:57
@filipesilva filipesilva mentioned this pull request Oct 2, 2017
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hansl hansl hansl requested changes

Assignees

@hansl hansl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@filipesilva @hansl @googlebot