-
Notifications
You must be signed in to change notification settings - Fork 12k
feat(@ngtools/webpack): add AngularCompilerPlugin #7512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -18,4 +18,4 @@ test_script: | |
build: off | ||
|
||
cache: | ||
- node_modules | ||
- node_modules -> package-lock.json | ||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,6 +2,7 @@ import { CliConfig } from '../models/config'; | |
import { BuildOptions } from '../models/build-options'; | ||
import { Version } from '../upgrade/version'; | ||
import { oneLine } from 'common-tags'; | ||
import { AngularCompilerPlugin } from '@ngtools/webpack'; | ||
|
||
const Command = require('../ember-cli/lib/models/command'); | ||
|
||
|
@@ -176,6 +177,13 @@ export const baseBuildCommandOptions: any = [ | |
aliases: ['nc'], | ||
description: 'Use file name for lazy loaded chunks.', | ||
default: buildConfigDefaults['namedChunks'] | ||
}, | ||
{ | ||
name: 'experimental-angular-compiler', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I thought we were getting rid of this by using a version check. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nevermind, that will happen once we have JIT support. |
||
type: Boolean, | ||
aliases: ['eac'], | ||
description: 'Use new Angular Compiler (Angular version 5 and greater only).', | ||
default: AngularCompilerPlugin.isSupported() | ||
} | ||
]; | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does the package-lock.json means here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's how that cache gets invalidated, I was having trouble with this PR in appveyour and had to invalidate it properly.