Skip to content
This repository was archived by the owner on Feb 9, 2020. It is now read-only.

0.10.8 broken #310

Closed
BigGillyStyle opened this issue Mar 31, 2017 · 5 comments
Closed

0.10.8 broken #310

BigGillyStyle opened this issue Mar 31, 2017 · 5 comments

Comments

@BigGillyStyle
Copy link

BigGillyStyle commented Mar 31, 2017 •
edited
Loading

OS: macOS 10.12.4
Chrome: 57.0.2987.133 (64-bit)
Batarang: 0.10.8

This extension was working fine until this morning when I assumed it updated to 0.10.8. I can examine scopes, but if I click the "Enable" checkbox in the AngularJS tab within the Chrome DevTools I get the following error many times and the extension crashes:

VM859 extensions::schemaUtils:112 Uncaught Error: Invocation of form runtime.connect(null, ) doesn't match definition runtime.connect(optional string extensionId, optional object connectInfo)
    at Object.normalizeArgumentsAndValidate (VM859 extensions::schemaUtils:112)
    at Object.<anonymous> (VM854 extensions::binding:411)
    at Object.<anonymous> (VM853 extensions::runtime:129)
    at Object.handleRequest (VM854 extensions::binding:63)
    at Object.<anonymous> (VM854 extensions::binding:422)

(probably separate issue) I following the Readme instructions to downgrade to 0.10.7 (after removing 0.10.8), but the AngularJS tab is just an empty page. I tried the Chrome Beta channel as well using 0.10.8, but I got the same JS error in the console.
@gkalpak
Copy link
Member

gkalpak commented Mar 31, 2017

Thx for reporting. We are aware and working on a fix. Expect v0.10.9 soon 😁

This was referenced Mar 31, 2017
Closed
Closed
gkalpak added a commit to gkalpak/batarang that referenced this issue Apr 2, 2017
@gkalpak
fix(hint):
45aaf78 
Somewhere betwen v0.14.4 and v4.0.0, EventEmitter2 started being inconsistent
wrt to the arguments passed to the `onAny()` listener; sometimes the `eventType`
is passed as the first argument, sometimes it's not. This caused batarang to
crash.

This commit fixes it, by accounting for the fact that `eventType` might or might
not be passed as a first argument.

Fixes angular#310
gkalpak added a commit to gkalpak/batarang that referenced this issue Apr 2, 2017
@gkalpak
fix(hint): do not crash
cf7cf1f 
Somewhere between v0.14.4 and v4.0.0, `EventEmitter2` started being inconsistent
wrt to the arguments passed to the `onAny()` listener; sometimes the `eventType`
is passed as the first argument, sometimes it isn't. This caused batarang to
crash.

This commit fixes it, by accounting for the fact that `eventType` might or might
not be passed as a first argument.

Fixes angular#310
@gkalpak gkalpak mentioned this issue Apr 2, 2017
Closed
gkalpak added a commit to gkalpak/batarang that referenced this issue Apr 2, 2017
@gkalpak
fix(hint): do not crash
852d723 
Somewhere between v0.14.4 and v4.0.0, `EventEmitter2` started being inconsistent
wrt to the arguments passed to the `onAny()` listener; sometimes the `eventType`
is passed as the first argument, sometimes it isn't. This caused batarang to
crash.

This commit fixes it, by accounting for the fact that `eventType` might or might
not be passed as a first argument.

Fixes angular#310
@JoshSchreuder
Copy link

Thanks for updating @gkalpak, glad to see Angular 1 tooling is still being maintained 😄

gkalpak added a commit to gkalpak/batarang that referenced this issue Apr 4, 2017
@gkalpak
fix(hint): do not crash
a8336d4 
Somewhere between v0.14.4 and v4.0.0, `EventEmitter2` started being inconsistent
wrt to the arguments passed to the `onAny()` listener; sometimes the `eventType`
is passed as the first argument, sometimes it isn't. This caused batarang to
crash.

This commit fixes it, by accounting for the fact that `eventType` might or might
not be passed as a first argument.

Fixes angular#310
@gkalpak gkalpak closed this as completed in 4369cbc Apr 4, 2017
@gkalpak
Copy link
Member

gkalpak commented Apr 4, 2017

v0.10.9 has been uploaded to the Chrome Web Store. Should be published in a few mins.

@BigGillyStyle
Copy link
Author

Totally fixed my issue. Thanks @gkalpak ...that was a faster response than I ever expected 😄

@gkalpak
Copy link
Member

gkalpak commented Apr 4, 2017

Well, if you break it, you have to fix it 😉
That said there seems to be another issue with false reports: "Module X was created but never loaded." 😞

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@JoshSchreuder @BigGillyStyle @gkalpak