Fix crash introduced in v0.10.8 and slightly improve loader #311
Conversation
gkalpak
force-pushed
the
fix-loader-small-improvements
branch
from
da45ed9 to
f3d9cf8
Compare
| @@ -101,8 +109,7 @@ function bufferData(tabId, message) { | |||
| // context script –> background | |||
| chrome.runtime.onMessage.addListener(brokerMessage); | |||
|
|
|||
| chrome.runtime.onConnect.addListener(function(devToolsPort) { | |||
|
|
|||
| chrome.runtime.onConnect.addListener(function (devToolsPort) { | |||
There was a problem hiding this comment.
what is it with adding spaces after function?
There was a problem hiding this comment.
It falls under the random changes category 😃
Both variations are used throughout the project - it drives me crazy. I was trying to blend in with the rest of the file 😁
| @@ -71,13 +72,20 @@ function bufferData(tabId, message) { | |||
| } | |||
|
|
|||
| if (message.event === 'scope:new') { | |||
| tabData.scopes[message.data.child] = { | |||
There was a problem hiding this comment.
I note that this change no longer modifies the tabData.scope object. Is that on purpose?
There was a problem hiding this comment.
It does. I just stored some properties as local var (childScopeData = tabData.scopes[childId]).
There was a problem hiding this comment.
At no point do you write to tabData.scopes[message.data.child] any more
There was a problem hiding this comment.
the childScopeData never gets assigned onto the tabData.scopes object.
There was a problem hiding this comment.
So, this was used to "hydrate" the Scopes view when the DevTools would open, at which point the DevTools app would take over maintaining the scopes info. With my incorrect change, the scopes would not be hydrated when you opened DevTools, so you needed to refresh the app with the DevTools open.
Thx for watching out for my blunders 😃
It really sucks that there are no substancial tests. Hoping to fix it some time.
hint.js
Outdated
| severity = data; | ||
| data = event; | ||
| event = this.event; | ||
| } |
|
Fixed the |
Somewhere between v0.14.4 and v4.0.0, `EventEmitter2` started being inconsistent wrt to the arguments passed to the `onAny()` listener; sometimes the `eventType` is passed as the first argument, sometimes it isn't. This caused batarang to crash. This commit fixes it, by accounting for the fact that `eventType` might or might not be passed as a first argument. Fixes angular#310
…d `minErr` This commit updates `loader.js` based on `angular-loader.js` from angular/angular.js#15881, which is essentially the latest loader plus some `minErr` fixes (see angular/angular.js#15881 for more info). Additionally, the loader does a better job staying closer to the original `angular-loader` behavior for versions 1.3+ and it only modifies its behavior to support 1.2 apps. This change also fixes previously broken usecases that rely on private `angular.Module` APIs (see angular#88 for more info). Fixes angular#88
gkalpak
force-pushed
the
fix-loader-small-improvements
branch
from
68f8830 to
1e5bd10
Compare
This PR includes:
minErr-related fixes (see fix(angular-loader): do not depend on "closure" globals that may not be available angular.js#15881).Fixes #88, #310.