-
Notifications
You must be signed in to change notification settings - Fork 6.8k
refactor(multiple): fix warnings related to division operator in latest version of Sass #22871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0e8d0e7
to
7aa3bd9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one minor nit from my side.
7aa3bd9
to
15c6e77
Compare
@jelbourn one thing we may want to consider here: the |
15c6e77
to
20bcfd8
Compare
I've reworked the changes to make them backwards-compatible with Sass less than 1.34.0. |
20bcfd8
to
c7d76cf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…st version of Sass The latest version of Sass prints a warning when the division operator is used. These changes migrate us to the recommended `math.div` function. Fixes angular#22866.
c7d76cf
to
25126cd
Compare
How do I know when this is going to be released ? Thanks in advance. |
It'll be released in version 12.1. |
I am seeing it in 12.0.6 but not in any of the newer versions like 12.1.1 for example. Is this expected? |
That sounds weird since we only merged it into the 12.1.0 branch. |
Never mind! My mistake 😅 |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
The latest version of Sass prints a warning when the division operator is used. These changes migrate us to the recommended
math.div
function.Note: there a few warnings left from MDC. I've submitted material-components/material-components-web#7158 to address them.
More information: https://sass-lang.com/documentation/breaking-changes/slash-div
Fixes #22866.