Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

md-nav-item ignores disabled-attribute #9667

Closed
Jentsch opened this issue Sep 22, 2016 · 8 comments · Fixed by #10992
Closed

md-nav-item ignores disabled-attribute #9667

Jentsch opened this issue Sep 22, 2016 · 8 comments · Fixed by #10992
Assignees
@Splaktar
Labels
has: Pull Request A PR has been created to address this issue P4: minor Minor issues. May not be fixed without community contributions. resolution: fixed
Milestone
1.1.8

Comments

@Jentsch
Copy link

Jentsch commented Sep 22, 2016

Actual Behavior:

  • What is the issue? * md-nav-item ignores disabled-attribute
  • What is the expected behavior? shown in the demo as manual disabled

CodePen (or steps to reproduce the issue): *

  • CodePen Demo which shows your issue: http://codepen.io/anon/pen/ozBBya
  • Details: notice the difference between the two tabs "Attempt to disable" and "Manual disabled"

Angular Versions: *

  • Angular Version: 1.5.5
  • Angular Material Version: 1.1.0

Additional Information:

  • Browser Type: * tested on desktop, but assume all
  • Browser Version: * tested firefox and chrome, but assume all
  • OS: *tested on Linux, but assume all
  • Stack Traces: no
@crisbeto
Copy link
Member

You might want to update your Codepen since it uses disable="1" instead of disabled="1". After changing, the behaviour still seems broken though.

@Jentsch
Copy link
Author

Jentsch commented Sep 22, 2016

Thanks, I updated the codepen.

@maxjoehnk
Copy link
Contributor

There is no support for the disabled attribute on md-nav-item right now.
I've already opened a pull request for ng-disabled and disabled support.

#9613

@Jentsch
Copy link
Author

Jentsch commented Sep 22, 2016

In this case I close this issue, because it is a duplicate of #9613.

@Jentsch Jentsch closed this as completed Sep 22, 2016
@maxjoehnk maxjoehnk mentioned this issue Jan 3, 2017
Closed
@devversion devversion reopened this Jan 3, 2017
@devversion devversion added the has: Pull Request A PR has been created to address this issue label Jan 3, 2017
@ThomasBurleson ThomasBurleson added this to the 1.2.0 milestone Jan 3, 2017
@ThomasBurleson ThomasBurleson added needs: presubmit pr: merge ready This PR is ready for a caretaker to review and removed needs: presubmit labels Jan 3, 2017
@changran52m
Copy link

So, any updates here?

@fsmeier
Copy link
Contributor

fsmeier commented Aug 9, 2017

@maxjoehnk any updates? the two PRs are closed as far as i see it.

@pnag90
Copy link

pnag90 commented Oct 16, 2017

Any update? @maxjoehnk

@Splaktar Splaktar added - needs: Pull Request and removed pr: merge ready This PR is ready for a caretaker to review has: Pull Request A PR has been created to address this issue labels Nov 21, 2017
@Splaktar
Copy link
Contributor

@maxjoehnk had another PR (#10202) but like #9613 he ran into issues with a bad rebase and the PR was closed.

If Max or someone else would like to re-submit the PR, we would be happy to take a look at a clean PR and try to get it merged.

@Splaktar Splaktar modified the milestones: 1.2.0, - Backlog Nov 21, 2017
@currensy currensy mentioned this issue Nov 21, 2017
Closed
currensy added a commit to currensy/material that referenced this issue Nov 21, 2017
@currensy
feat(navBar): add disabled attribute
3fd2a51 
* Originally developed by: @maxjoehnk . I'm just resubmitting
* Add disabled attribute to navitem
* Update demo to showcase ng-disabled and disabled usage
* Add tests
* Ignore navbar specific button styling when disabled

fixes angular#9667
@currensy currensy mentioned this issue Nov 21, 2017
Merged
@Splaktar Splaktar modified the milestones: - Backlog, 1.1.6 Nov 21, 2017
@Splaktar Splaktar added for: external contributor has: Pull Request A PR has been created to address this issue P4: minor Minor issues. May not be fixed without community contributions. and removed - needs: Pull Request labels Nov 21, 2017
@Splaktar Splaktar modified the milestones: 1.1.6, 1.1.7 Jan 17, 2018
@Splaktar Splaktar modified the milestones: 1.1.7, 1.1.8 Feb 7, 2018
@Splaktar Splaktar self-assigned this Feb 7, 2018
currensy pushed a commit to currensy/material that referenced this issue Feb 7, 2018
@jelbourn @currensy
fix(compiler): assign bindings to controller instance when using an E…
27aae04 
…S6 (angular#10977)

class and preAssignBindingsEnabled == false

feat(navBar): add disabled attribute

* Originally developed by: @maxjoehnk . I'm just resubmitting
* Add disabled attribute to navitem
* Update demo to showcase ng-disabled and disabled usage
* Add tests
* Ignore navbar specific button styling when disabled

fixes angular#9667

feat(navBar): add disabled attribute

* Implemented suggested changes to follow the convention and use parseAttributeBoolean() function from $mdUtils

feat(navBar): add disabled attribute

* Implemented suggested changes added MutationObserver and removed unnecessary style changes
currensy added a commit to currensy/material that referenced this issue Feb 8, 2018
@currensy
feat(navBar): add disabled attribute
cd2f8a3 
* Originally developed by: @maxjoehnk . I'm just resubmitting
* Add disabled attribute to navitem
* Update demo to showcase ng-disabled and disabled usage
* Add tests
* Ignore navbar specific button styling when disabled

fixes angular#9667
currensy added a commit to currensy/material that referenced this issue Feb 18, 2018
@currensy
feat(navBar): add disabled attribute
d6ee485 
* Originally developed by: @maxjoehnk . I'm just resubmitting
* Add disabled attribute to navitem
* Update demo to showcase ng-disabled and disabled usage
* Add tests
* Ignore navbar specific button styling when disabled

fixes angular#9667
mmalerba pushed a commit that referenced this issue Mar 16, 2018
@currensy @mmalerba
feat(navBar): add disabled attribute (#10992)
b4d36f3 
* Originally developed by: @maxjoehnk . I'm just resubmitting
* Add disabled attribute to navitem
* Update demo to showcase ng-disabled and disabled usage
* Add tests
* Ignore navbar specific button styling when disabled

fixes #9667
chmelevskij pushed a commit to chmelevskij/material that referenced this issue Jun 19, 2018
@currensy @chmelevskij
feat(navBar): add disabled attribute (angular#10992)
c935bea 
* Originally developed by: @maxjoehnk . I'm just resubmitting
* Add disabled attribute to navitem
* Update demo to showcase ng-disabled and disabled usage
* Add tests
* Ignore navbar specific button styling when disabled

fixes angular#9667
Splaktar pushed a commit that referenced this issue Jul 31, 2018
@currensy @Splaktar
feat(navBar): add disabled attribute (#10992)
24f33e2 
* Originally developed by: @maxjoehnk . I'm just resubmitting
* Add disabled attribute to navitem
* Update demo to showcase ng-disabled and disabled usage
* Add tests
* Ignore navbar specific button styling when disabled

fixes #9667
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Splaktar Splaktar

Labels
has: Pull Request A PR has been created to address this issue P4: minor Minor issues. May not be fixed without community contributions. resolution: fixed
Projects
None yet
Milestone
1.1.8
9 participants
@ThomasBurleson @Jentsch @maxjoehnk @fsmeier @changran52m @Splaktar @crisbeto @devversion @pnag90