This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(compiler): assign bindings to controller instance when using an ES6 class and preAssignBindingsEnabled == false #10977
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
class and preAssignBindingsEnabled == false
jelbourn
force-pushed
the
compiler-fix-es6-class
branch
from
b96073f to
20567a9
Compare
mmalerba
approved these changes
Nov 9, 2017
gillyb
pushed a commit
to gillyb/material
that referenced
this pull request
Jan 25, 2018
…S6 (angular#10977) class and preAssignBindingsEnabled == false Save the original currentTarget of swipe events Place currentTarget declaration in correct scope Add documentation Be consistent
Splaktar
added a commit
that referenced
this pull request
Jan 28, 2018
"should assign bindings by $onInit for ES6 classes" fails on 1.4 add missing shebang Relates to #10977
3 tasks
jelbourn
pushed a commit
that referenced
this pull request
Jan 29, 2018
"should assign bindings by $onInit for ES6 classes" fails on 1.4 add missing shebang Relates to #10977
currensy
pushed a commit
to currensy/material
that referenced
this pull request
Feb 7, 2018
…S6 (angular#10977) class and preAssignBindingsEnabled == false feat(navBar): add disabled attribute * Originally developed by: @maxjoehnk . I'm just resubmitting * Add disabled attribute to navitem * Update demo to showcase ng-disabled and disabled usage * Add tests * Ignore navbar specific button styling when disabled fixes angular#9667 feat(navBar): add disabled attribute * Implemented suggested changes to follow the convention and use parseAttributeBoolean() function from $mdUtils feat(navBar): add disabled attribute * Implemented suggested changes added MutationObserver and removed unnecessary style changes
chmelevskij
pushed a commit
to chmelevskij/material
that referenced
this pull request
Jun 19, 2018
"should assign bindings by $onInit for ES6 classes" fails on 1.4 add missing shebang Relates to angular#10977
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.