Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

fix(compiler): assign bindings to controller instance when using an ES6 class and preAssignBindingsEnabled == false #10977

Merged
merged 1 commit into from
Nov 14, 2017

Conversation

jelbourn
Copy link
Member

@jelbourn jelbourn commented Nov 8, 2017

No description provided.

@jelbourn jelbourn requested a review from crisbeto November 8, 2017 20:05
@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Nov 8, 2017
@jelbourn jelbourn force-pushed the compiler-fix-es6-class branch from b96073f to 20567a9 Compare November 8, 2017 23:14
@jelbourn jelbourn requested a review from mmalerba November 8, 2017 23:36
@mmalerba mmalerba added the pr: lgtm This PR has been approved by the reviewer label Nov 9, 2017
@jelbourn jelbourn merged commit f4b19fe into angular:master Nov 14, 2017
@Splaktar Splaktar added this to the 1.1.6 milestone Jan 7, 2018
gillyb pushed a commit to gillyb/material that referenced this pull request Jan 25, 2018
…S6 (angular#10977)

class and preAssignBindingsEnabled == false

Save the original currentTarget of swipe events

Place currentTarget declaration in correct scope

Add documentation

Be consistent
Splaktar added a commit that referenced this pull request Jan 28, 2018
"should assign bindings by $onInit for ES6 classes" fails on 1.4
add missing shebang

Relates to #10977
jelbourn pushed a commit that referenced this pull request Jan 29, 2018
"should assign bindings by $onInit for ES6 classes" fails on 1.4
add missing shebang

Relates to #10977
currensy pushed a commit to currensy/material that referenced this pull request Feb 7, 2018
…S6 (angular#10977)

class and preAssignBindingsEnabled == false

feat(navBar): add disabled attribute

* Originally developed by: @maxjoehnk . I'm just resubmitting
* Add disabled attribute to navitem
* Update demo to showcase ng-disabled and disabled usage
* Add tests
* Ignore navbar specific button styling when disabled

fixes angular#9667

feat(navBar): add disabled attribute

* Implemented suggested changes to follow the convention and use parseAttributeBoolean() function from $mdUtils

feat(navBar): add disabled attribute

* Implemented suggested changes added MutationObserver and removed unnecessary style changes
chmelevskij pushed a commit to chmelevskij/material that referenced this pull request Jun 19, 2018
"should assign bindings by $onInit for ES6 classes" fails on 1.4
add missing shebang

Relates to angular#10977
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ pr: lgtm This PR has been approved by the reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants