Allow for custom server addresses when running against SauceLabs.

[DylanLacey]

Sauce Connect can tunnel Selenium traffic, not just Browser traffic. This is often used in restricted networking environments.

This is supported by running Sauce Connect, then pointing your remote WebDriver to the Sauce Connect machine rather then ondemand.saucelabs.com.

This PR lets you specify a seleniumAddress as well as a sauceUser and sauceKey, and still use Sauce with job status updating et al.

[DylanLacey]

It didn't look like that build failure was due to this PR; I'm not entirely sure, JS isn't my native programming language:P

[juliemr]

Automated CLA checker says: please sign CLA at https://developers.google.com/open-source/cla/individual Please make sure that the email associated with your PR is the same as the email you use to sign.

[juliemr]

CLA signature found, thank you!

[DylanLacey]

Is there anything I can do to help get this merged in? Some more evidence I can provide or better testing?

[ChandanNM]

Hello,

We at Cisco Systems tested Dylan's patch on our Jenkins restricted environment. The changes work great and our test framework can now connect and run the tests on Sauce. We approve the changes and is there a possibility this can be merged soon so we can go by the official protractor version and don't have to keep the hack we currently have for long.

Thanks in advance,

• Chandan

[juliemr]

Hi folks,

I've added this to the 1.X milestone - we're trying to minimize changes before 1.0 which are not stability fixes, but this will be added shortly after. Thanks for your patience!

[DylanLacey]

Ah, OK Julie, totally understandable! Good luck with 1.0.

On Fri, Jul 18, 2014 at 10:04 AM, Julie Ralph [email protected]
wrote:

Hi folks,

I've added this to the 1.X milestone - we're trying to minimize changes
before 1.0 which are not stability fixes, but this will be added shortly
after. Thanks for your patience!

—
Reply to this email directly or view it on GitHub
#1054 (comment).

Dylan LaceyDeveloper Evangelist
Twitter: @DylanLacey
Github: @DylanLacey
Sauce Labs http://saucelabs.com/ | Sauce blog http://sauceio.com/
Talk to us anytime: [image: Twitter] https://twitter.com/saucelabs [image:
LinkedIn] https://www.linkedin.com/company/sauce-labs [image: Google+]
https://plus.google.com/+SauceLabs_Official/posts [image: Facebook]
https://www.facebook.com/saucelabs

[juliemr]

What do you think about requiring the user to be more explicit, by adding a new parameter to the config instead of re-using SeleniumAddress? Then we wouldn't have to change the order of priorities that's being given right now. You could make it config.sauceSeleniumAddress.

[DylanLacey]

Yeah, that's a great idea; As you say the extra explicitness will make it
clear what it's for and there won't be "two ways" to achieve the Saucy goal.

I'll make that change soon and push the commit up. Great suggestion!

On Tue, Jul 22, 2014 at 1:08 PM, Julie Ralph [email protected]
wrote:

What do you think about requiring the user to be more explicit, by adding
a new parameter to the config instead of re-using SeleniumAddress? Then we
wouldn't have to change the order of priorities that's being given right
now. You could make it config.sauceSeleniumAddress.

—
Reply to this email directly or view it on GitHub
#1054 (comment).

Dylan LaceyDeveloper Evangelist
Twitter: @DylanLacey
Github: @DylanLacey
Sauce Labs http://saucelabs.com/ | Sauce blog http://sauceio.com/
Talk to us anytime: [image: Twitter] https://twitter.com/saucelabs [image:
LinkedIn] https://www.linkedin.com/company/sauce-labs [image: Google+]
https://plus.google.com/+SauceLabs_Official/posts [image: Facebook]
https://www.facebook.com/saucelabs

[juliemr]

Ping? This seems useful so I think I'll just go ahead and make the update on top of this PR.

[juliemr]

Updated and merged as cd575ee. Thanks!

[DylanLacey]

Ah dangit. This is what happens when I read GitHub tickets in my email and don't add tasks to my todo list. Sorry, and thanks for compensating for my general derposity >.> I owe you one Free as in $BEVERAGE.