This repository was archived by the owner on Jul 29, 2024. It is now read-only.
fix(runner): prefer sauce to hosted driver when sauceKey is present #1115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sauce Connect sets up a local Selenium relay at localhost:4445 by default. Allow users to adjust the `seleniumAddress` to point at this secure relay instead of the default 'ondemand.saucelabs.com' host while still using the `sauce` driver provider. Previously, runner would load the `remote` driver provider if `seleniumAddress` was configured, even if Sauce credentials were also configured.
|
Automated CLA checker says: please sign CLA at https://developers.google.com/open-source/cla/individual Please make sure that the email associated with your PR is the same as the email you use to sign. |
|
This looks like a dupe of #1054, correct? |
|
yup 100%. my bad! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sauce Connect sets up a local Selenium relay at localhost:4445 by
default. Allow users to adjust the
seleniumAddressto point at thissecure relay instead of the default
ondemand.saucelabs.comhost whilestill using the
saucedriver provider.Previously, runner would load the
remotedriver provider ifseleniumAddresswas configured, even if Sauce credentials were alsoconfigured.
For reasons not clear to me, on Travis VMs, the Sauce Connect relay is 10x more reliable than
ondemand.saucelabs.com. It might be worth testing whether this helps with protractor's test suite oddities (#1051 and #1052)