Skip to content
This repository was archived by the owner on Jul 29, 2024. It is now read-only.

fix(restart): typescript fix for browser.restart #3658

Merged
merged 1 commit into from
Oct 25, 2016

Conversation

cnishina
Copy link
Contributor

closes #3648

@cnishina
Copy link
Contributor Author

with tests and improvements!

@@ -1,5 +1,7 @@
node_modules
typings
conf.js
browserts_spec.js
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these be here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I have a browserts_spec.ts that transpiles to browserts_spec.js. I also have a similar test for javascript with browserjs_spec.js.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooooooooooooooooooooh. gotcha

@heathkit heathkit merged commit b67d8eb into angular:master Oct 25, 2016
@cnishina cnishina deleted the fix_browser branch November 7, 2016 23:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

This driver instance does not have a valid session ID after browser.restart()
3 participants