Skip to content
This repository was archived by the owner on Jul 29, 2024. It is now read-only.

fix(restart): typescript fix for browser.restart #3658

Merged
merged 1 commit into from
Oct 25, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion lib/runner.ts
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,13 @@ export class Runner extends EventEmitter {
// calls here are not guaranteed to complete before the tests resume.
this.driverprovider_.quitDriver(browser_.driver);
// Copy mock modules, but do not navigate to previous URL.
browser_ = browser_.forkNewDriverInstance(false, true);
let forkBrowser = browser_.forkNewDriverInstance(false, true);

// Replace the items in browser_ but do not create a new object
// since this will break typescript imports
for (let item in forkBrowser) {
browser_[item] = forkBrowser[item];
}
this.setupGlobals_(browser_);
};

Expand Down
4 changes: 3 additions & 1 deletion spec/install/.gitignore
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
node_modules
typings
conf.js
browserts_spec.js
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these be here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I have a browserts_spec.ts that transpiles to browserts_spec.js. I also have a similar test for javascript with browserjs_spec.js.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooooooooooooooooooooh. gotcha

typescript_conf.js
typescript_spec.js
npm-debug.log
npm-debug.log
30 changes: 30 additions & 0 deletions spec/install/browserjs_spec.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
describe('browser', () => {
let session1;
let session2;

afterEach(() => {
browser.restart();
});

it('should load a browser session', (done) => {
browser.get('http://angularjs.org');
browser.getSession().then(session => {
session1 = session.getId();
expect(session1).not.toBeUndefined();
}).catch(err => {
done.fail('session should be defined');
});
done();
});
it('should have a new browser session', (done) => {
browser.get('http://angularjs.org');
browser.getSession().then(session => {
session2 = session.getId();
expect(session2).not.toBeUndefined();
expect(session1).not.toEqual(session2);
}).catch(err => {
done.fail('session should be defined');
});
done();
});
});
33 changes: 33 additions & 0 deletions spec/install/browserts_spec.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
import {browser} from 'protractor';
import {WebDriver} from 'selenium-webdriver';

describe('browser', () => {
let session1: string;
let session2: string;

afterEach(() => {
browser.restart();
});

it('should load a browser session', (done) => {
browser.get('http://angularjs.org');
browser.getSession().then(session => {
session1 = session.getId();
expect(session1).not.toBeUndefined();
}).catch(err => {
done.fail('session should be defined');
});
done();
});
it('should have a new browser session', (done) => {
browser.get('http://angularjs.org');
browser.getSession().then(session => {
session2 = session.getId();
expect(session2).not.toBeUndefined();
expect(session1).not.toEqual(session2);
}).catch(err => {
done.fail('session should be defined');
});
done();
});
});
10 changes: 8 additions & 2 deletions spec/install/conf.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,13 @@
import {Config} from 'protractor';

var env = require('../environment');

export let config: Config = {
mockSelenium: true,
specs: ['*_spec.js'],
seleniumAddress: env.seleniumAddress,
capabilities: env.capabilities,
specs: [
'browserts_spec.js',
'browserjs_spec.js'
],
framework: 'jasmine'
}
7 changes: 4 additions & 3 deletions spec/install/test.js
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,10 @@ function tsc() {
}
}

function test() {
function test(file) {
var options = {cwd: __dirname};
var output = TestUtils.runCommand('node',
['node_modules/protractor/bin/protractor','conf.js'],
['node_modules/protractor/bin/protractor',file],
options);
if (output && output[1]) {
console.log(output[1].toString());
Expand All @@ -60,4 +60,5 @@ function test() {

install();
tsc();
test();
test('conf.js');
test('typescript_conf.js');
7 changes: 7 additions & 0 deletions spec/install/typescript_conf.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
import {Config} from 'protractor';

export let config: Config = {
mockSelenium: true,
specs: ['typescript_spec.js'],
framework: 'jasmine'
}