Skip to content

Modernize project layout #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 15 commits into from
Closed

Modernize project layout #299

wants to merge 15 commits into from

Conversation

jorgepiloto
Copy link
Member

@jorgepiloto jorgepiloto commented Jul 9, 2022

Resolves #296 by:

  • Moving from setup.py to pyproject.toml.
  • Collecting developer dependencies in a common requirements/ directory.
  • Collect extra dependencies within pyproject.toml.
  • Move tools configuration to pyproject.toml.
  • Enable pre-commit for style checking.
  • Updating .github/ workflows to new layout.
  • Protection rules for branch "main" must point to new actions

@jorgepiloto
Copy link
Member Author

I just noticed that scooby is used for reporting. Shouldn't we use ansys-report-tool? Pinging here @PProfizi for having feedback on this question. Also, pinging @RobPasMue, as he is the main maintainer of ansys-report-tool.

@jorgepiloto
Copy link
Member Author

I just noticed that scooby is used for reporting. Shouldn't we use ansys-report-tool? Pinging here @PProfizi for having feedback on this question. Also, pinging @RobPasMue, as he is the main maintainer of ansys-report-tool.

Maybe the migration to ansys-tools-report can be made in a separate PR so this one does not get too complex.

@jorgepiloto jorgepiloto force-pushed the maint/pkg-layout branch 2 times, most recently from 95438fc to d3e6f31 Compare July 10, 2022 15:59
@jorgepiloto
Copy link
Member Author

Note: documentation is using the old PyAnsys logo.

@PProfizi
Copy link
Contributor

I just noticed that scooby is used for reporting. Shouldn't we use ansys-report-tool? Pinging here @PProfizi for having feedback on this question. Also, pinging @RobPasMue, as he is the main maintainer of ansys-report-tool.

Maybe the migration to ansys-tools-report can be made in a separate PR so this one does not get too complex.

Hi @jorgepiloto, indeed this has been something to be done, a separate PR would be better.

@PProfizi
Copy link
Contributor

Note: documentation is using the old PyAnsys logo.

Hi @jorgepiloto, this is being modified here

@RobPasMue
Copy link
Member

I just noticed that scooby is used for reporting. Shouldn't we use ansys-report-tool? Pinging here @PProfizi for having feedback on this question. Also, pinging @RobPasMue, as he is the main maintainer of ansys-report-tool.

Maybe the migration to ansys-tools-report can be made in a separate PR so this one does not get too complex.

Hi @jorgepiloto, indeed this has been something to be done, a separate PR would be better.

Hi @jorgepiloto @PProfizi I can handle this in a new PR. Already done it for PyMAPDL :) See example: ansys/pymapdl#1215

@jorgepiloto
Copy link
Member Author

I'm closing this after realizing that addressing so many changes in a single PR is going to be a drama for reviewers but also pretty complex to develop while other changes are being implemented.

@jorgepiloto jorgepiloto deleted the maint/pkg-layout branch July 13, 2022 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update package layout to PyAnsys guidelines
3 participants