-
Notifications
You must be signed in to change notification settings - Fork 132
Implement pyansys-tools-report in PyMAPDL #1215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Not really understanding why its complaining... importlib.metadata should be available, since it is part of the pyproject.toml reqs... |
Codecov Report
@@ Coverage Diff @@
## main #1215 +/- ##
==========================================
+ Coverage 78.02% 78.04% +0.01%
==========================================
Files 43 43
Lines 6777 6777
==========================================
+ Hits 5288 5289 +1
+ Misses 1489 1488 -1 |
Why is it complaining about coverage?? @akaszynski @germa89 I understand that you want 90% or more in your library... but as far as I can tell... my changes are covered. Is it requiring me to cover more of the PyMAPDL code? |
The issue is that these lines were not originally covered. Let's cover this in a separate PR if needed, unless you want to add coverage for these lines. |
Understood, no worries. I'll set up some more tests. Thanks @akaszynski for the explanation. |
The remaining lines can not be easily tested:
I consequently propose to close this PR as is... Solving the coverage for those conditions would be too much work for the gain they suppose... Pinging @akaszynski @germa89 for feedback |
@germa89 can we try and close this one? =) |
Merged without coverage check. It wasn't worthy. Thank you @RobPasMue !! |
Closes #1195