GH-47740: [C++][Parquet] Fix undefined behavior when reading invalid Parquet data #47741
+18
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@github-actions crossbow submit -g cpp |
|
@AntoinePrv Would you like to take a look? |
pitrou
commented
Oct 7, 2025
| // There may be remaining null if they are not greedily filled by either decoder calls | ||
| check_and_handle_fully_null_remaining(); | ||
|
|
||
| ARROW_DCHECK(batch.is_done() || exhausted()); |
There was a problem hiding this comment.
This check could trigger if the RLE-bit-packed data is invalid (for example a run of invalid size). @AntoinePrv
pitrou
changed the title
|
Revision: d620685 Submitted crossbow builds: ursacomputing/crossbow @ actions-0059c16459
|
github-actions
bot
added
awaiting committer review
|
Valgrind failure is unrelated and will be fixed by #47743 |
adamreeve
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Fix issues found by OSS-Fuzz when invalid Parquet data is fed to the Parquet reader:
Are these changes tested?
Yes, using the updated fuzz regression files from apache/arrow-testing#115
Are there any user-facing changes?
No.
This PR contains a "Critical Fix". (If the changes fix either (a) a security vulnerability, (b) a bug that caused incorrect or invalid data to be produced, or (c) a bug that causes a crash (even when the API contract is upheld), please provide explanation. If not, you can remove this.)