Remove record_fields from the Record class
#580
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First step towards apache#579
Fokko
added a commit
to Fokko/Daft
that referenced
this pull request
May 27, 2024
I would like to clean up this method: apache/iceberg-python#580
Fokko
added a commit
to Fokko/Daft
that referenced
this pull request
May 27, 2024
I would like to clean up this method: apache/iceberg-python#580
Fokko
added a commit
to Fokko/Daft
that referenced
this pull request
May 27, 2024
I would like to clean up this method: apache/iceberg-python#580
Fokko
added a commit
to Fokko/Daft
that referenced
this pull request
May 27, 2024
I would like to clean up this method: apache/iceberg-python#580
Fokko
added a commit
to Fokko/Daft
that referenced
this pull request
May 27, 2024
I would like to clean up this method: apache/iceberg-python#580
jaychia
pushed a commit
to Eventual-Inc/Daft
that referenced
this pull request
May 28, 2024
I would like to clean up the `record_fields()` method: apache/iceberg-python#580 You should not check the name of the `_partition` since it can be anything (technically). In Iceberg we look up the partition by position based on the partition spec.
HonahX
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First step towards #579