Skip to content

Conversation

panzhi33
Copy link
Contributor

@panzhi33 panzhi33 commented Nov 3, 2021

Make sure set the target branch to develop

What is the purpose of the change

XXXXX

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

import org.apache.rocketmq.client.log.ClientLogger;
import org.apache.rocketmq.logging.InternalLogger;

public class RequestFutureTable {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that the name of RequestFutureTable is no longer appropriate when so many functions are put in

@duhenglucky duhenglucky changed the base branch from master to develop November 3, 2021 06:24
@coveralls
Copy link

coveralls commented Nov 3, 2021

Coverage Status

Coverage increased (+0.009%) to 54.537% when pulling 3d7226c on panzhi33:master into 2385f04 on apache:develop.

@yuz10 yuz10 merged commit 7f1c14c into apache:develop Dec 10, 2021
@yuz10 yuz10 linked an issue Dec 10, 2021 that may be closed by this pull request
@vongosling vongosling added this to the 4.9.3 milestone Dec 10, 2021
areyouok pushed a commit that referenced this pull request Dec 15, 2021
 (#3639)

Fix producer/consumer re-start may fail introduced in #3454

1. start a producer 
2. shutdown producer
3. start the second producer, exception throws
devfat pushed a commit to devfat/rocketmq that referenced this pull request Mar 3, 2022
* [ISSUE apache#3453]Producer cannot shutdown completely

* [ISSUE apache#3453]Producer cannot shutdown completely

* [ISSUE apache#3453]Producer cannot shutdown completely

Co-authored-by: panzhi33 <[email protected]>
devfat pushed a commit to devfat/rocketmq that referenced this pull request Mar 3, 2022
… in apache#3454 (apache#3639)

Fix producer/consumer re-start may fail introduced in apache#3454

1. start a producer 
2. shutdown producer
3. start the second producer, exception throws
GenerousMan pushed a commit to GenerousMan/rocketmq that referenced this pull request Aug 12, 2022
* [ISSUE apache#3453]Producer cannot shutdown completely

* [ISSUE apache#3453]Producer cannot shutdown completely

* [ISSUE apache#3453]Producer cannot shutdown completely

Co-authored-by: panzhi33 <[email protected]>
GenerousMan pushed a commit to GenerousMan/rocketmq that referenced this pull request Aug 12, 2022
… in apache#3454 (apache#3639)

Fix producer/consumer re-start may fail introduced in apache#3454

1. start a producer 
2. shutdown producer
3. start the second producer, exception throws
carlvine500 pushed a commit to carlvine500/rocketmq-apache that referenced this pull request Sep 10, 2024
* [ISSUE apache#3453]Producer cannot shutdown completely

* [ISSUE apache#3453]Producer cannot shutdown completely

* [ISSUE apache#3453]Producer cannot shutdown completely

Co-authored-by: panzhi33 <[email protected]>
carlvine500 pushed a commit to carlvine500/rocketmq-apache that referenced this pull request Sep 10, 2024
… in apache#3454 (apache#3639)

Fix producer/consumer re-start may fail introduced in apache#3454

1. start a producer 
2. shutdown producer
3. start the second producer, exception throws
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Producer cannot shutdown completely
5 participants