-
Notifications
You must be signed in to change notification settings - Fork 12k
[ISSUE #3453]Producer cannot shutdown completely #3454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RongtongJin
reviewed
Nov 3, 2021
import org.apache.rocketmq.client.log.ClientLogger; | ||
import org.apache.rocketmq.logging.InternalLogger; | ||
|
||
public class RequestFutureTable { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that the name of RequestFutureTable is no longer appropriate when so many functions are put in
RongtongJin
approved these changes
Nov 4, 2021
6 tasks
yuz10
approved these changes
Dec 10, 2021
areyouok
pushed a commit
that referenced
this pull request
Dec 15, 2021
devfat
pushed a commit
to devfat/rocketmq
that referenced
this pull request
Mar 3, 2022
* [ISSUE apache#3453]Producer cannot shutdown completely * [ISSUE apache#3453]Producer cannot shutdown completely * [ISSUE apache#3453]Producer cannot shutdown completely Co-authored-by: panzhi33 <[email protected]>
devfat
pushed a commit
to devfat/rocketmq
that referenced
this pull request
Mar 3, 2022
… in apache#3454 (apache#3639) Fix producer/consumer re-start may fail introduced in apache#3454 1. start a producer 2. shutdown producer 3. start the second producer, exception throws
GenerousMan
pushed a commit
to GenerousMan/rocketmq
that referenced
this pull request
Aug 12, 2022
* [ISSUE apache#3453]Producer cannot shutdown completely * [ISSUE apache#3453]Producer cannot shutdown completely * [ISSUE apache#3453]Producer cannot shutdown completely Co-authored-by: panzhi33 <[email protected]>
GenerousMan
pushed a commit
to GenerousMan/rocketmq
that referenced
this pull request
Aug 12, 2022
… in apache#3454 (apache#3639) Fix producer/consumer re-start may fail introduced in apache#3454 1. start a producer 2. shutdown producer 3. start the second producer, exception throws
carlvine500
pushed a commit
to carlvine500/rocketmq-apache
that referenced
this pull request
Sep 10, 2024
* [ISSUE apache#3453]Producer cannot shutdown completely * [ISSUE apache#3453]Producer cannot shutdown completely * [ISSUE apache#3453]Producer cannot shutdown completely Co-authored-by: panzhi33 <[email protected]>
carlvine500
pushed a commit
to carlvine500/rocketmq-apache
that referenced
this pull request
Sep 10, 2024
… in apache#3454 (apache#3639) Fix producer/consumer re-start may fail introduced in apache#3454 1. start a producer 2. shutdown producer 3. start the second producer, exception throws
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure set the target branch to
develop
What is the purpose of the change
XXXXX
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR
.[ISSUE #123] Fix UnknownException when host config not exist
. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle
to make sure basic checks pass. Runmvn clean install -DskipITs
to make sure unit-test pass. Runmvn clean test-compile failsafe:integration-test
to make sure integration-test pass.