Skip to content

Conversation

yuz10
Copy link
Member

@yuz10 yuz10 commented Dec 9, 2021

Make sure set the target branch to develop

What is the purpose of the change

fix #3609

Brief changelog

The scheduledExecutorService is created at class init, need to call shutdown whether its used or not.

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@yuz10
Copy link
Member Author

yuz10 commented Dec 9, 2021

#3453 #3454

@yuz10 yuz10 closed this Dec 9, 2021
@yuz10 yuz10 deleted the yuz10-patch-1 branch December 9, 2021 11:14
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 54.376% when pulling 062e0cb on yuz10-patch-1 into 21faa68 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

producer not stop after shutdown since #3199
2 participants