Introduced pipfile #376
Introduced pipfile #376
Conversation
Just created by pipenv install -r ci-requirements.txt
|
Thanks Mori |
Pipfile
Outdated
|
|
||
| [packages] | ||
| selenium = "==3.141.0" | ||
| astroid = "==1.6.5" |
There was a problem hiding this comment.
should we differentiate its version based on py3/py2?
There was a problem hiding this comment.
No, 1.6.5 is enough I think.
astroid is used by pylint. Pylint 1.9.3 is necessary to run it for both versions.
Once we drop Python 2.7, we can remove this deps and update the pylint, too.
There was a problem hiding this comment.
Then it makes sense to keep a TODO comment there
| @@ -0,0 +1,19 @@ | |||
| [[source]] | |||
There was a problem hiding this comment.
we can also explicitly point out which python versions are supported here
There was a problem hiding this comment.
You mean [requires] section?
If so, I removed from below description.
If no and you have example, it would be helpful.
https://docs.pipenv.org/en/latest/basics/#general-recommendations-version-control
Specify your target Python version in your Pipfile’s [requires] section. Ideally, you should only have one target Python version, as this is a deployment tool.
There was a problem hiding this comment.
yeah, sad but true: pypa/pipenv#1050
Pipfile
Outdated
| httpretty = "==0.9.6" | ||
| pytest = "==4.0.2" | ||
| pytest-cov = "==2.6.0" | ||
| tox = "==3.6.0" |
There was a problem hiding this comment.
I would say it is fine to use any minor version above this rather than equal to
| tox = "~=3.6" | ||
| tox-travis = "~=0.11" | ||
|
|
||
| # TODO Update to the latest ver when py2 support dropped |
There was a problem hiding this comment.
I mean you could do something like unittest2 = {version = ">=1.0,<3.0", markers="python_version < '2.7.9' or (python_version >= '3.0' and python_version < '3.4')"}
There was a problem hiding this comment.
Yes, but at least for pylint/astroid/isort, point is #362 (comment) .
And as for other packages, same package versions are available for both py2 and py3.
For #365