Skip to content

Introduced pipfile #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 14, 2019
Merged

Introduced pipfile #376

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6f5ad0f
Added Pipfile
ki4070ma May 7, 2019
47e59fe
Introduced pipenv
ki4070ma May 13, 2019
ed12b6f
Add Pipfile.lock to gitignore
ki4070ma May 13, 2019
5ce8f39
Cover any minor versions for packages
ki4070ma May 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,3 +22,5 @@ __pycache__
# Virtual Environments
venv*
.tox

Pipfile.lock
21 changes: 21 additions & 0 deletions Pipfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
[[source]]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can also explicitly point out which python versions are supported here

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean [requires] section?

If so, I removed from below description.
If no and you have example, it would be helpful.

https://docs.pipenv.org/en/latest/basics/#general-recommendations-version-control

Specify your target Python version in your Pipfile’s [requires] section. Ideally, you should only have one target Python version, as this is a deployment tool.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, sad but true: pypa/pipenv#1050

name = "pypi"
url = "https://pypi.org/simple"
verify_ssl = true

[dev-packages]
pre-commit = "~=1.13"

[packages]
selenium = "~=3.141"
autopep8 = "~=1.4"
httpretty = "~=0.9"
pytest = "~=4.0"
pytest-cov = "~=2.6"
tox = "~=3.6"
tox-travis = "~=0.11"

# TODO Update to the latest ver when py2 support dropped
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean you could do something like unittest2 = {version = ">=1.0,<3.0", markers="python_version < '2.7.9' or (python_version >= '3.0' and python_version < '3.4')"}

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but at least for pylint/astroid/isort, point is #362 (comment) .

And as for other packages, same package versions are available for both py2 and py3.

pylint = "~=1.9"
astroid = "~=1.6"
isort = "~=4.3"
3 changes: 2 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,8 @@ download and unarchive the source tarball (Appium-Python-Client-X.X.tar.gz).
- You can customise `CHANGELOG.rst` with commit messages following [.gitchangelog.rc](.gitchangelog.rc)
- It generates readable changelog
- Setup
- `pip install -r development.txt`
- `pip install --user pipenv`
- `pipenv install --dev`
- `pre-commit install`

## Run tests
Expand Down
10 changes: 0 additions & 10 deletions ci-requirements.txt
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions development.txt
View file
Open in desktop

This file was deleted.

4 changes: 3 additions & 1 deletion tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ envlist =

[testenv]
deps =
-r ci-requirements.txt
pipenv
commands =
pipenv lock --clear
pipenv install
./ci.sh