Fix build for Android armv7 #328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Fix compilation error because of a type mismatch between st_mode and mode_t on 32-bit Android. Modifications: - Zero-extend mode_t constants on Android armv7 to match the types. - Scope an earlier modification in this vein to armv7 only. Result: The code builds on Android armv7 again.
Lukasa
approved these changes
Oct 13, 2021
|
Thanks! ✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Fix compilation error because of a type mismatch between
st_modeandmode_ton 32-bit Android.Modifications:
mode_tconstants on Android armv7 to match the types.Result:
The code builds on Android armv7 again.
This line just added in #327 yesterday broke the armv7 build on my daily Android CI. Adding these conversions fixes it and I went ahead and scoped the earlier change from #45 more narrowly too.