Skip to content

fix Android support #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 5, 2018
Merged

fix Android support #45

merged 3 commits into from
Oct 5, 2018

Conversation

albertaleksieiev
Copy link
Contributor

Android support

Motivation:
fix swift-nio-ssl compatible with Android. This is a continuation(apple/swift-nio#609) of porting Vapor/WebSocket and all related packages to Android.

Modifications:
fix FileSystemObject::pathType and sysStat Android API inconsistency

Result:
now swift-nio-ssl compatible with Android!

@swift-nio-bot
Copy link

Can one of the admins verify this patch?

2 similar comments
@swift-nio-bot
Copy link

Can one of the admins verify this patch?

@swift-nio-bot
Copy link

Can one of the admins verify this patch?

@albertaleksieiev
Copy link
Contributor Author

@weissi @Lukasa can you please check my changes guys, thanks! I continue porting swift-nio to Android 🤗

Copy link
Member

@weissi weissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks! Just one #if Android that I don’t understand but this can go in really soon!

@weissi
Copy link
Member

weissi commented Oct 3, 2018

@swift-nio-bot please test

@weissi
Copy link
Member

weissi commented Oct 3, 2018

@swift-nio-bot test this please

Copy link
Member

@weissi weissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thanks!

@weissi
Copy link
Member

weissi commented Oct 5, 2018

@swift-nio-bot test this please

@albertaleksieiev
Copy link
Contributor Author

@weissi great! Thanks!

@weissi weissi merged commit db16c3a into apple:master Oct 5, 2018
@weissi
Copy link
Member

weissi commented Oct 5, 2018

@albertaleksieiev thank you! merged. Would it be beneficial to you to get a release (tagged version) pretty soon or don't you mind at all when the first release will be containing the Android fixes?

@albertaleksieiev
Copy link
Contributor Author

@weissi take your time, just ping me before release if it possible, I'll test it on Android.

@weissi
Copy link
Member

weissi commented Oct 5, 2018

@albertaleksieiev thanks! Fairly sure that we'll make a release soon with what is master today. So if it works now I think we should be good right?

@albertaleksieiev
Copy link
Contributor Author

albertaleksieiev commented Oct 7, 2018

@weissi oh great, happy to hear it 👍Yep, current master state is fully compatible with Android.

@weissi
Copy link
Member

weissi commented Oct 8, 2018

Awesome, thanks for checking! I’d expect a release next week, Cory is on holiday right now and we don’t usually do releases unless we’re both there as a second pair of eyes is always good when releasing 😁

@albertaleksieiev
Copy link
Contributor Author

Sounds great! BTW thanks for quick responses 👍

@Lukasa Lukasa added the 🆕 semver/minor Adds new public API. label Oct 16, 2018
@Lukasa Lukasa added this to the 1.4.0 milestone Oct 16, 2018
@Lukasa
Copy link
Contributor

Lukasa commented Oct 16, 2018

Cool, we can arrange a release for this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🆕 semver/minor Adds new public API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants