-
Notifications
You must be signed in to change notification settings - Fork 155
fix Android support #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Can one of the admins verify this patch? |
2 similar comments
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks! Just one #if Android
that I don’t understand but this can go in really soon!
@swift-nio-bot please test |
@swift-nio-bot test this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome, thanks!
@swift-nio-bot test this please |
@weissi great! Thanks! |
@albertaleksieiev thank you! merged. Would it be beneficial to you to get a release (tagged version) pretty soon or don't you mind at all when the first release will be containing the Android fixes? |
@weissi take your time, just ping me before release if it possible, I'll test it on Android. |
@albertaleksieiev thanks! Fairly sure that we'll make a release soon with what is |
@weissi oh great, happy to hear it 👍Yep, current master state is fully compatible with Android. |
Awesome, thanks for checking! I’d expect a release next week, Cory is on holiday right now and we don’t usually do releases unless we’re both there as a second pair of eyes is always good when releasing 😁 |
Sounds great! BTW thanks for quick responses 👍 |
Cool, we can arrange a release for this week. |
Android support
Motivation:
fix
swift-nio-ssl
compatible with Android. This is a continuation(apple/swift-nio#609) of portingVapor/WebSocket
and all related packages to Android.Modifications:
fix
FileSystemObject::pathType
andsysStat
Android API inconsistencyResult:
now
swift-nio-ssl
compatible with Android!