Skip to content

The Settings dialog spans horizontally when IDE is on full-screen mode #1158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 tasks done
kittaakos opened this issue Jul 8, 2022 · 1 comment · Fixed by #1172
Closed
3 tasks done

The Settings dialog spans horizontally when IDE is on full-screen mode #1158

kittaakos opened this issue Jul 8, 2022 · 1 comment · Fixed by #1172
Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project

Comments

@kittaakos
Copy link
Contributor

kittaakos commented Jul 8, 2022

Describe the problem

When the IDE is on full-screen mode, the Settings dialog looks like this:

Screen Shot 2022-07-08 at 10 59 52

To reproduce

  • Start IDE,
  • Put into full-screen mode,
  • Open the Settings

Expected behavior

Screen Shot 2022-07-08 at 11 51 12

Arduino IDE version

Version: 2.0.0-rc8-nightly-20220708 Date: 2022-07-08T03:32:00.911Z CLI Version: 0.24.0 [c1b10f56] Copyright © 2022 Arduino SA

Operating system

macOS

Operating system version

12.3.1

Additional context

Proposed fix by @91volt:

diff --git a/arduino-ide-extension/src/browser/style/dialogs.css b/arduino-ide-extension/src/browser/style/dialogs.css
index 3ce0092..4340cf9 100644
--- a/arduino-ide-extension/src/browser/style/dialogs.css
+++ b/arduino-ide-extension/src/browser/style/dialogs.css
@@ -10,6 +10,7 @@
     */
     max-width: calc(100% - 96px) !important;
     padding: 0 28px;
+    width: 740px;
 }
 
 .p-Widget.dialogOverlay .dialogBlock .dialogTitle {

Issue checklist

  • I searched for previous reports in the issue tracker
  • I verified the problem still occurs when using the latest nightly build
  • My report contains all necessary details
@kittaakos kittaakos added type: imperfection Perceived defect in any part of project topic: code Related to content of the project itself labels Jul 8, 2022
@kittaakos
Copy link
Contributor Author

I noticed another regression in the dialog's height.

RC-8:

rc-8_dialog_height.mp4

Nightly:

nigthly_dialog_height.mp4

@per1234 per1234 added the conclusion: resolved Issue was resolved label Jul 14, 2022
@per1234 per1234 changed the title The Settings dialog spans horizontally when IDE2 is on full-screen mode The Settings dialog spans horizontally when IDE is on full-screen mode Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants