Skip to content

Fix settings dialog size #1172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 14, 2022
Merged

Fix settings dialog size #1172

merged 2 commits into from
Jul 14, 2022

Conversation

AlbyIanna
Copy link
Contributor

@AlbyIanna AlbyIanna commented Jul 11, 2022

Motivation

The max-width rule of the settings dialog is being overridden by the default dialog max-width, resulting in a VERY big (and ugly) dialog. Also, the height of the dialog shouldn't change when switching to the Network tab.

Change description

  • give an id to the settings dialog html element and use it in the css rule to grant it a higher priority.
  • fix settings dialog height

Other information

The credit for this fix goes to @davegarthsimpson, who suggested it 🌼
Fixes #1158

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@kittaakos
Copy link
Contributor

The dialog width is correct now, thank you for the fix, but the height of the Network tab is incorrect. (See here) Is there a chance to fix both issues together?

@per1234 per1234 added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Jul 11, 2022
@AlbyIanna
Copy link
Contributor Author

The dialog width is correct now, thank you for the fix, but the height of the Network tab is incorrect. (See here) Is there a chance to fix both issues together?

Thank you, I didn't notice it.

Fixed👍

@AlbyIanna AlbyIanna changed the title Fix settings dialog width Fix settings dialog size Jul 14, 2022
Copy link
Contributor

@kittaakos kittaakos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works as expected. Thank you!

@AlbyIanna AlbyIanna merged commit fb690c9 into main Jul 14, 2022
@AlbyIanna AlbyIanna deleted the fix-settings-dialog-width branch July 14, 2022 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Settings dialog spans horizontally when IDE is on full-screen mode
3 participants