fix(py_venv): Implement collision handling #578
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch extends the new static venv machinery to handle conflicts in the logical venv path. Support is preliminary but complete, a multi-pass venv creation strategy would be better for producing comprehensive errors rather than forcing users to whack-a-mole.
Fixes #575
Changes are visible to end-users: yes
Test plan
error
mode conflicting venv is brokenwarn
mode conflicting venv produces a warningignore
mode conflicting venv is silent