Skip to content

Extend Quickgrid with Id and Style Properties #45327 #559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

korteksz
Copy link

@korteksz korteksz commented Dec 5, 2022

Extend Quickgrid with Id and Style Properties #45327

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue

Summary of the changes (Less than 80 chars)

Description

Extend Quickgrid.cs with Id and Style Properties

More details about the problem: dotnet/aspnetcore#45327

Fixes #45327

@SteveSandersonMS
Copy link
Member

Thanks for suggesting this! Rather than being limited to id and style, do you think it would make sense to just pass through arbitrary attributes? This would use a CaptureUnmatchedValues parameter. Then developers can do:

<QuickGrid id="..." tabindex="..." spellcheck="...">...</QuickGrid>

... or whatever other custom attributes they want to use.

@korteksz
Copy link
Author

@SteveSandersonMS Thanks for the suggestion. I've adapted the code accordingly. Hope it is fine now :)

@Nick-Stanton
Copy link
Contributor

Hi @korteksz, thank you for your contribution! QuickGrid has now been productized in dotnet/aspnetcore#46317 and will no longer receive changes here. When convenient, please open a new PR against the version in the ASP.NET Core repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants