Pass through arbitrary attributes to QuickGrid

[ElderJames]

Pass through arbitrary attributes to QuickGrid

• You've read the Contributor Guide and Code of Conduct.
• You've included unit or integration tests for your change, where applicable.
• You've included inline docs for your change, where applicable.
• There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Summary of the changes (Less than 80 chars)

Add the AdditionalAttributes parameter with CaptureUnmatchedValues flag and pass through to QuickGrid table element.

Description

Follow up aspnet/AspLabs#559 (comment)

Fixes #45327

[ghost]

Thanks for your PR, @ElderJames. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

[SteveSandersonMS]

Thanks @ElderJames! This is looking really good.

One small issue will arise with this implementation, though. The grid already generates a class attribute automatically adding both quickgrid and a loading class that toggles based on any associated ItemsProvider. The implementation here will overwrite that if the developer provides any class attribute, thereby breaking the "loading" indicator and other styles.

To solve this, I would suggest:

• When the grid is rendered at https://github.com/dotnet/aspnetcore/pull/48268/files#diff-6d509929f1d48812b35dbac8a474371c00e27c0932219e323dc11cfff82ea460R13, move the class="@GridClass()" to be after the @attributes. Then GridClass will always take precedence.
• Change the implementation of GridClass so that, if the developer has supplied AdditionalAttributes, it looks for any class entry in that dictionary and appends it to the GridClass result value.

This would preserve existing behaviors while also letting the developer add extra classes using a normal class attribute.

[ElderJames]

Thanks for your suggestions @SteveSandersonMS , I have fixed this. But I'm a little confused about the test and why the style won't be passed to the table.

[ghost]

Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime.
To make sure no breaking changes are introduced, please leave an /azp run comment here to rerun the CI pipeline and confirm success before merging the change.

[ElderJames]

Hello @SteveSandersonMS , could you please teach me how to solve the style attribute issue?

[mkArtakMSFT]

Thanks for your PR.
Glad to see updated tests too. There is just one minor optimization I've left a comment about and then I think this will be in good shape to take.

[mkArtakMSFT]

You can utilize the AttributeUtilities.CombineClassNames method instead:

aspnetcore/src/Components/Web/src/Forms/AttributeUtilities.cs

Line 10 in 33243ad

public static string? CombineClassNames(IReadOnlyDictionary<string, object>? additionalAttributes, string? classNames)

Here is a usage example in the CssClass property of the InputBase type;

aspnetcore/src/Components/Web/src/Forms/InputBase.cs

Line 187 in 33243ad

protected string CssClass

[ElderJames]

Thank you @mkArtakMSFT , I have done the changes, but AttributeUtilities.CombineClassNames is internal that can't be accessed in QuickGrid library. How to solve that?

[SteveSandersonMS]

Thanks for the update. This is now ready to merge, except for fixing the final compiler issue. We need it to go in today, so I've made the necessary change and am continuing the PR in #50051, so will close this PR in favour of that. The new PR still uses the original commits from here so hopefully @ElderJames will still be credited as the author.