Exclude docker secrets for preview2 #216
Conversation
|
|
|
cc @JunTaoLuo |
| @@ -156,7 +156,7 @@ Microsoft.Extensions.Configuration.Abstractions,ship,include | |||
| Microsoft.Extensions.Configuration.AzureKeyVault,ship,include | |||
| Microsoft.Extensions.Configuration.Binder,ship,include | |||
| Microsoft.Extensions.Configuration.CommandLine,ship,include | |||
| Microsoft.Extensions.Configuration.DockerSecrets,ship,include | |||
| Microsoft.Extensions.Configuration.DockerSecrets,noship,include | |||
There was a problem hiding this comment.
noship,include is a strange combination. We don't want to ship this package but want to include it in the runtime store?
There was a problem hiding this comment.
Yeah I had it as exclude but from https://github.com/aspnet/Coherence-Signed/wiki/New-package-Id-creation it sounds like that's a tool/framework bit since noship trumps that flag anyways
There was a problem hiding this comment.
Functionally, we aren't even really making use of the include/exclude flag right now since it's all controlled by what's going into the MetaPackage reference. There's is a work item aspnet/MetaPackages#19 to eventually generate what we have in the MetaPackage based on this file so it's a good idea to keep it up to date as if it were used to generate the runtime store.
There was a problem hiding this comment.
Ok, I'll flip it to exclude
No description provided.