Skip to content
This repository was archived by the owner on Feb 23, 2021. It is now read-only.

Exclude docker secrets for preview2 #216

Closed
wants to merge 1 commit into from
Closed

Exclude docker secrets for preview2 #216

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/packages.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ Microsoft.Extensions.Configuration.Abstractions,ship,include
Microsoft.Extensions.Configuration.AzureKeyVault,ship,include
Microsoft.Extensions.Configuration.Binder,ship,include
Microsoft.Extensions.Configuration.CommandLine,ship,include
Microsoft.Extensions.Configuration.DockerSecrets,ship,include
Microsoft.Extensions.Configuration.DockerSecrets,noship,include
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noship,include is a strange combination. We don't want to ship this package but want to include it in the runtime store?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I had it as exclude but from https://github.com/aspnet/Coherence-Signed/wiki/New-package-Id-creation it sounds like that's a tool/framework bit since noship trumps that flag anyways

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionally, we aren't even really making use of the include/exclude flag right now since it's all controlled by what's going into the MetaPackage reference. There's is a work item aspnet/MetaPackages#19 to eventually generate what we have in the MetaPackage based on this file so it's a good idea to keep it up to date as if it were used to generate the runtime store.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I'll flip it to exclude

Microsoft.Extensions.Configuration.EnvironmentVariables,ship,include
Microsoft.Extensions.Configuration.FileExtensions,ship,include
Microsoft.Extensions.Configuration.Ini,ship,include
Expand Down