This repository was archived by the owner on Nov 2, 2018. It is now read-only.
Dispose service instances only once #661
Closed
+53
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure that instances that are marked for later disposal are only disposed once even if they are retrieved through multiple separate ways.
ilmax
reviewed
Oct 22, 2018
| @@ -48,10 +48,12 @@ public void Dispose() | |||
| _disposed = true; | |||
| if (_disposables != null) | |||
| { | |||
| var disposed = new HashSet<IDisposable>(); | |||
There was a problem hiding this comment.
new HashSet<IDisposable>(_disposables.Count) ?
|
@poke thanks for the PR. I'm going to close this because we're merging this repo with https://github.com/aspnet/Extensions. After #662 has been merged, please feel free to re-open this PR over there. cc @davidfowl |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for aspnet/AspNetCore#2932. Unfortunately, just changing the collection to a hash set would not work as #505 requires this to be an ordered collection. So instead, I’m remembering what services I have disposed at the time they get disposed.
An alternative solution would be to have the hash set around as an instance member to avoid adding duplicate services to the collection. This would have the benefit that services are disposed in the reversed order of their first use. With this fix, they are disposed in the order of their last use. Not sure which of those is better; this version at least avoids having a second collection around all the time.