Skip to content
This repository was archived by the owner on Nov 2, 2018. It is now read-only.

Dispose service instances only once #661

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -742,5 +742,55 @@ public void ResolvesDifferentInstancesForServiceWhenResolvingEnumerable(Type ser
Assert.Equal(service, enumerable[2]);
}
}

[Fact]
public void ServicesAreDisposedOnlyOnce_SingletonInRootScope()
{
// Arrange
var collection = new TestServiceCollection();
collection.AddSingleton<FakeService>();
collection.AddSingleton<IFakeService>(sp => sp.GetService<FakeService>());
var provider = CreateServiceProvider(collection);

// Act & Assert
var service = provider.GetService<IFakeService>();
var service2 = provider.GetService<FakeService>();

(provider as IDisposable).Dispose();
}

[Fact]
public void ServicesAreDisposedOnlyOnce_ScopedInScope()
{
// Arrange
var collection = new TestServiceCollection();
collection.AddScoped<FakeService>();
collection.AddScoped<IFakeService>(sp => sp.GetService<FakeService>());
var provider = CreateServiceProvider(collection);

// Act & Assert
using (var scope = provider.CreateScope())
{
var service1 = scope.ServiceProvider.GetService<IFakeService>();
var service2 = scope.ServiceProvider.GetService<FakeService>();
}
}

[Fact]
public void ServicesAreDisposedOnlyOnce_TransientInScope()
{
// Arrange
var collection = new TestServiceCollection();
collection.AddTransient<FakeService>();
collection.AddTransient<IFakeService>(sp => sp.GetService<FakeService>());
var provider = CreateServiceProvider(collection);

// Act & Assert
using (var scope = provider.CreateScope())
{
var service1 = scope.ServiceProvider.GetService<IFakeService>();
var service2 = scope.ServiceProvider.GetService<FakeService>();
}
}
}
}
4 changes: 3 additions & 1 deletion src/DI/ServiceLookup/ServiceProviderEngineScope.cs
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,12 @@ public void Dispose()
_disposed = true;
if (_disposables != null)
{
var disposed = new HashSet<IDisposable>();
Copy link

@ilmax ilmax Oct 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new HashSet<IDisposable>(_disposables.Count) ?

for (var i = _disposables.Count - 1; i >= 0; i--)
{
var disposable = _disposables[i];
disposable.Dispose();
if (disposed.Add(disposable))
disposable.Dispose();
}

_disposables.Clear();
Expand Down