Skip to content
This repository was archived by the owner on Mar 19, 2019. It is now read-only.

[1.1.x patch] Fix API set target #349

Closed
Tratcher opened this issue Apr 20, 2017 · 9 comments
Closed

[1.1.x patch] Fix API set target #349

Tratcher opened this issue Apr 20, 2017 · 9 comments
Assignees

Comments

@Tratcher
Copy link
Member

#347
@jchannon

@jchannon
Copy link
Contributor

Excuse my lack of internal MS workflow but where do we go from this issue being marked as a "patch-proposed" to a patch?

@Eilon
Copy link
Contributor

Eilon commented Apr 25, 2017

@jchannon this issue is not currently slated for a patch release. Would it be possible for you to use a custom build of the package? Or use a 2.0.0 nightly build (where this issue is already fixed).

@jchannon
Copy link
Contributor

jchannon commented Apr 25, 2017 via email

@Eilon
Copy link
Contributor

Eilon commented Apr 25, 2017

@jchannon yeah using 2.0 would mean using nightly 2.0 bits for the whole app. Would that work for you?

It should be pretty easy to make your own build: just clone the repo on Windows/Mac/Linux to the right branch/tag, make the change, and run build - it'll produce all the required NuGet packages and DLLs.

@muratg
Copy link

muratg commented Jun 23, 2017

@Eilon should we close this one? (And #348)

@Eilon
Copy link
Contributor

Eilon commented Jul 18, 2017

Why close it?

@muratg
Copy link

muratg commented Jul 28, 2017

@Eilon IIRC, this was rejected for the previous patch release.

@Eilon
Copy link
Contributor

Eilon commented Jul 28, 2017

Ok... if there are bugs we don't want to consider for the patch, go ahead and close 😄

@muratg
Copy link

muratg commented Oct 5, 2017

Closing this. The bug is fixed in 2.0.0 RTM, and we don't plan to bring the fix back to 1.x.

@muratg muratg closed this as completed Oct 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants