Skip to content
This repository was archived by the owner on Mar 19, 2019. It is now read-only.

Fix API set target #347

Merged
merged 1 commit into from
Apr 20, 2017
Merged

Fix API set target #347

merged 1 commit into from
Apr 20, 2017

Conversation

Tratcher
Copy link
Member

#326
WebListener targets api-ms-win-core-io-l1-1-1.dll for CancelIoEx, but it's actually defined in api-ms-win-core-io-l1-1-0.dll. This is fine on Win8+, but it fails on Win7. This causes an EntryPointNotFoundException when calling the method.

@Tratcher Tratcher added this to the 2.0.0-preview1 milestone Apr 19, 2017
@Tratcher Tratcher self-assigned this Apr 19, 2017
@Tratcher Tratcher requested a review from moozzyk April 19, 2017 23:16
@Tratcher
Copy link
Member Author

@jchannon

@jchannon
Copy link
Contributor

jchannon commented Apr 20, 2017

👍 :shipit:

Will this be release as part of netcore2 or a patch to HttpSysServer nuget package or a general patch to the dll that will automatically be pulled in if I publish a self contained app?

I assume 2.0.0-preview1 means netcore2?

@Tratcher Tratcher merged commit 76a4299 into dev Apr 20, 2017
@Tratcher Tratcher deleted the tratcher/apiset branch April 20, 2017 17:22
@Tratcher
Copy link
Member Author

Tratcher commented Apr 20, 2017

@jchannon This commit is for ASP.NET Core 2.0. I'll file additional bugs proposing a backport in the next 1.1.x and 1.0.x patches. The patches would require a manual update.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants