This repository was archived by the owner on Dec 18, 2018. It is now read-only.
Don't throw in HttpRequestStream.Flush #2342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kekekeks you need to fix the tests |
|
|
bartonjs
reviewed
Feb 22, 2018
| @@ -38,7 +38,6 @@ public override long Position | |||
|
|
|||
| public override void Flush() | |||
| { | |||
| throw new NotSupportedException(); | |||
| } | |||
|
|
|||
| public override Task FlushAsync(CancellationToken cancellationToken) | |||
There was a problem hiding this comment.
Presumably this should return Task.CompletedTask instead of throwing?
davidfowl
suggested changes
Feb 23, 2018
|
👌 |
Because read-only streams apparently can have Flush semantics and this behavior is expected by some of built-in stream wrappers (e. g. CryptoStream) dotnet/corefx#27327 (review) aspnet#2341
davidfowl
approved these changes
Feb 23, 2018
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because read-only streams apparently can have Flush semantics and this behavior is expected by some of built-in stream wrappers (e. g. CryptoStream)
dotnet/corefx#27327 (review)
#2341