This repository was archived by the owner on Dec 13, 2018. It is now read-only.
Added NullLoggerFactory to Logging.Abstractions #568
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eilon
suggested changes
Mar 9, 2017
|
|
||
| namespace Microsoft.Extensions.Logging.Abstractions | ||
| { | ||
| public class NullLoggerFactory : ILoggerFactory |
|
🆙 📅 |
Eilon
suggested changes
Mar 9, 2017
| @@ -3,15 +3,20 @@ | |||
|
|
|||
| namespace Microsoft.Extensions.Logging.Abstractions | |||
| { | |||
| /// <summary> | |||
| /// An <see cref="ILoggerFactory"/> used to create instance of <see cref="NullLogger"/>. | |||
There was a problem hiding this comment.
Might be worth adding some text that explicitly states that this logger never logs anything? Same goes for the methods below...
There was a problem hiding this comment.
It says that in the docs for NullLogger. Do we have to say that here too?
There was a problem hiding this comment.
I guess it doesn't hurt to add it here. Will update
ajaybhargavb
force-pushed
the
ajbaaska/null-logger
branch
from
60f329c to
3807733
Compare
|
🆙 📅 |
Eilon
suggested changes
Mar 9, 2017
|
|
||
| /// <inheritdoc /> | ||
| /// <remarks> | ||
| /// This method explicitly no ops. |
There was a problem hiding this comment.
I think this phrasing can be improved, no ops is nerd-speak. How about "This method ignores the parameter and does nothing."
Eilon
reviewed
Mar 9, 2017
|
|
||
| /// <inheritdoc /> | ||
| /// <remarks> | ||
| /// This returns a <see cref="NullLogger"/> instance which explicitly logs nothing. |
|
🆙 📅 |
Eilon
approved these changes
Mar 10, 2017
|
👏 That only took 8 hours |
ajaybhargavb
force-pushed
the
ajbaaska/null-logger
branch
from
61a228f to
b4ecccd
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue - #566
Removing
NullLogger*types from Logging.Testing will break other repos. That should be done separately.@Eilon @muratg