This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Show dock items on first run #685
Merged
+1,052
−892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that the Git panel is on the left but is also the one that is active
|
The builds appear to be failing because atom/atom#14125 hasn't hit stable yet. Will we still need to |
|
I think the beta failures are related to some test flake that's slipped in. I'll 🔧 those against master. |
BinaryMuse
commented
Apr 24, 2017
| }; | ||
| } | ||
|
|
||
| @autobind | ||
| rerender(callback) { | ||
| if (this.workspace.isDestroyed()) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
@smashwilson 🤔 What if the workspace isn't destroyed but the package is deactivated? Something we should handle in these cases?
There was a problem hiding this comment.
Good question. I'd hope that potential rerender() calls would be cleaned up by the CompositeDisposable disposal. But it's well worth a check to see if that's possible.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first time the package is loaded for a given project, this will show both panels in their default location. The Git panel will be on the left while the GitHub one will be on the right, and the Git panel will be the one that is active.
Fixes #673