Clean up my own messes #693

smashwilson · 2017-04-21T14:51:38Z

Help fix some build errors on #685 that were caused by the merge of #633.

Prevent calls to rerender() or updateActiveState() from completing after the environment has been destroyed.
Allow callers to destroy a Repository while it's still in the Loading state.
Do the same for the other states that have async start() methods (Initializing and Cloning most notably).
Prevent a DockItem from attempting to automatically activate its Pane if the Workspace is destroyed before it can.

BinaryMuse · 2017-04-24T18:15:50Z

Thanks! 🙇‍♀️

smashwilson added 11 commits April 21, 2017 10:43

Never render or update the active context after destruction

6d1b62b

Delegate git operations in async state methods to the current state

9ca2a3c

Make Loading.start() cancellable

ae017aa

Only permit state transitions initiated by the current state

d2ce103

Consolidate .then callbacks

fbbeb84

Don't activate after close

4304f5b

Allow DockItem to handle pane activation instead of Workspace.open()

a0160d6

Prevent Pane activation if the Workspace is destroyed

3120e65

Default useLegacyPanels correctly

511b9ac

Make init and clone cancellable

8e84ef5

Typo fix

cc99c80

BinaryMuse merged commit cc99c80 into mkt-show-panels-on-first-run Apr 24, 2017

smashwilson deleted the aw-async-destroy branch April 24, 2017 18:17

Provide feedback