feat(ng): evm tx fee widget #406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
11
to
23
| useEffect(() => { | ||
| let isMounted = true; | ||
|
|
||
| getNetworkFee(network.caipId).then((newFee) => { | ||
| if (isMounted) { | ||
| setNetworkFee(newFee); | ||
| } | ||
| }); | ||
|
|
||
| return () => { | ||
| isMounted = false; | ||
| }; | ||
| }, [getNetworkFee, network]); |
There was a problem hiding this comment.
There was a problem hiding this comment.
Removed all isMounted flags from apps/next, since the warning is not present anymore in React 18 and actually cancelling the promises would be a bigbig lift 🙌
bartosz-the-coder-at-avalabs
previously approved these changes
Aug 28, 2025
2 tasks
meeh0w
dismissed stale reviews from vvava and bartosz-the-coder-at-avalabs
via
fcc8c5e
vvava
approved these changes
Sep 5, 2025
gergelylovas
approved these changes
Sep 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the network fee widget for EVM transaction approval screens.
Testing
Custombutton and modify as you like)Screenshots:
EVM.Network.Fee.Widget.mov
Checklist for the author