Skip to content

Conversation

meeh0w
Copy link
Member

@meeh0w meeh0w commented Aug 29, 2025

Description

  • Adds token spend approval information and customizer to the EVM approval screen
  • Adds a placeholder approval screen for wallet-specific requests (like switching a chain), just to be able to interact with dApps.
  • Updates VM Modules with https://github.com/ava-labs/vm-modules/pull/304

Testing

  • Do a swap on core.app or lfj.gg such that it will trigger a token approval (if needed, you can revoke previous approvals on https://revoke.cash/)
    • Test both with limited and unlimited approvals
    • Customize the spend limit if available
  • List an NFT for sale on OpenSea
  • Send an NFT through OpenSea

Screenshots:

NFT Send through OpenSea

Screen.Recording.2025-08-29.at.20.09.43.mov

Listing an NFT through OpenSea

Screen.Recording.2025-08-29.at.20.11.00.mov

Token approval for LFJ.gg (via swap feature)

Screen.Recording.2025-08-29.at.20.12.38.mov

Checklist for the author

  • I've covered new/modified business logic with Jest test cases.
  • I've tested the changes myself before sending it to code review and QA.

@meeh0w meeh0w merged commit fcc8c5e into feat/ng-tx-evm-fees Sep 5, 2025
3 checks passed
@meeh0w meeh0w deleted the feat/ng-tx-evm-approvals branch September 5, 2025 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants