Skip to content

Block Size is limited to 256 bytes #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
facucc opened this issue May 18, 2024 · 3 comments
Closed

Block Size is limited to 256 bytes #24

facucc opened this issue May 18, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@facucc
Copy link

facucc commented May 18, 2024 •
edited
Loading

The mqttFileDownloader_CONFIG_BLOCK_SIZE variable limits sending blocks larger than 256 bytes.
The following lines show why it is limited to 256 bytes:
@kstribrnAmzn
Copy link
Member

You're correct! The MQTTFileDownloader.h file sets this to 256. This really should be a user configurable option as the block size is really limited to anwhere between 256 bytes to 128KB (see doc).

I'm going to mark this as a bug so that we update the repository to account for this.

@kstribrnAmzn kstribrnAmzn added the bug Something isn't working label May 30, 2024
kstribrnAmzn added a commit to kstribrnAmzn/aws-iot-core-mqtt-file-streams-embedded-c that referenced this issue May 30, 2024
@kstribrnAmzn
Add block size default
9044de4 
Block size for file transfer
should be configurable from 256 bytes to
128 KB.

Issue: aws#24
@kstribrnAmzn kstribrnAmzn mentioned this issue May 30, 2024
Merged
2 tasks
kstribrnAmzn added a commit to kstribrnAmzn/aws-iot-core-mqtt-file-streams-embedded-c that referenced this issue May 30, 2024
@kstribrnAmzn
Add block size default
d17e0a1 
Block size for file transfer
should be configurable from 256 bytes to
128 KB.

Issue: aws#24
kstribrnAmzn added a commit to kstribrnAmzn/aws-iot-core-mqtt-file-streams-embedded-c that referenced this issue May 30, 2024
@kstribrnAmzn
Add block size default
697b2c9 
Block size for file transfer
should be configurable from 256 bytes to
128 KB.

Issue: aws#24
kstribrnAmzn added a commit to kstribrnAmzn/aws-iot-core-mqtt-file-streams-embedded-c that referenced this issue May 30, 2024
@kstribrnAmzn
Add block size default
e3a0920 
Block size for file transfer
should be configurable from 256 bytes to
128 KB.

Issue: aws#24
kstribrnAmzn added a commit to kstribrnAmzn/aws-iot-core-mqtt-file-streams-embedded-c that referenced this issue May 30, 2024
@kstribrnAmzn
Add block size default
fbe86d6 
Block size for file transfer
should be configurable from 256 bytes to
128 KB.

Issue: aws#24
kstribrnAmzn added a commit to kstribrnAmzn/aws-iot-core-mqtt-file-streams-embedded-c that referenced this issue May 30, 2024
@kstribrnAmzn
Add block size default
0e20327 
Block size for file transfer
should be configurable from 256 bytes to
128 KB.

Issue: aws#24
kstribrnAmzn added a commit to kstribrnAmzn/aws-iot-core-mqtt-file-streams-embedded-c that referenced this issue May 30, 2024
@kstribrnAmzn
Add block size default
40f11d9 
Block size for file transfer
should be configurable from 256 bytes to
128 KB.

Issue: aws#24
kstribrnAmzn added a commit to kstribrnAmzn/aws-iot-core-mqtt-file-streams-embedded-c that referenced this issue May 30, 2024
@kstribrnAmzn
Add block size default
9beb9c8 
Block size for file transfer
should be configurable from 256 bytes to
128 KB.

Issue: aws#24
kstribrnAmzn added a commit to kstribrnAmzn/aws-iot-core-mqtt-file-streams-embedded-c that referenced this issue May 30, 2024
@kstribrnAmzn
Add block size default
ccda763 
Block size for file transfer
should be configurable from 256 bytes to
128 KB.

Issue: aws#24
@kstribrnAmzn
Copy link
Member

I've created #32 to remedy this.

kstribrnAmzn added a commit to kstribrnAmzn/aws-iot-core-mqtt-file-streams-embedded-c that referenced this issue May 30, 2024
@kstribrnAmzn
Add block size default
327157b 
Block size for file transfer
should be configurable from 256 bytes to
128 KB.

Issue: aws#24
@kstribrnAmzn
Copy link
Member

This fix is merged in. The block size is now configurable. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@facucc @kstribrnAmzn