Skip to content

Add block size default #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 31, 2024
Merged

Conversation

kstribrnAmzn
Copy link
Member

Description

Block size for file transfer
should be configurable from 256 bytes to
128 KB.

Test Steps

To be completed

Checklist:

  • I have tested my changes. No regression in existing tests.
  • I have modified and/or added unit-tests to cover the code changes in this Pull Request.

Related Issue

#24

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@kstribrnAmzn kstribrnAmzn requested a review from a team as a code owner May 30, 2024 20:02
@kstribrnAmzn kstribrnAmzn force-pushed the configBlockSize branch 8 times, most recently from 9beb9c8 to ccda763 Compare May 30, 2024 21:13
Copy link
Member

@paulbartell paulbartell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of small suggestions

Block size for file transfer
should be configurable from 256 bytes to
128 KB.

Issue: aws#24
@kstribrnAmzn kstribrnAmzn merged commit 690fb2b into aws:main May 31, 2024
10 checks passed
@kstribrnAmzn kstribrnAmzn deleted the configBlockSize branch May 31, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants