Skip to content

Conversation

aggarw13
Copy link
Contributor

@aggarw13 aggarw13 commented Aug 12, 2020

Address -Wunused-variable and -Wunused-parameter warnings in mqtt_lightweight_utest.c file

@aggarw13 aggarw13 changed the title [PR from CLI tool] Address -Wunused-variable and -Wunused-parameter warnings in lightwieght tests [PR from CLI tool] Address -Wunused-variable and -Wunused-parameter warnings in lightweight tests Aug 12, 2020
Copy link
Contributor

@muneebahmed10 muneebahmed10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Branch?

@aggarw13 aggarw13 changed the base branch from master to development August 12, 2020 17:35
@codecov-commenter
Copy link

Codecov Report

Merging #1117 into development will increase coverage by 1.91%.
The diff coverage is 81.48%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #1117      +/-   ##
===============================================
+ Coverage        96.54%   98.46%   +1.91%     
===============================================
  Files                9        4       -5     
  Lines             5643     1301    -4342     
  Branches           641      383     -258     
===============================================
- Hits              5448     1281    -4167     
+ Misses               9        0       -9     
+ Partials           186       20     -166     
Impacted Files Coverage Δ
libraries/standard/mqtt/src/mqtt.c 99.46% <ø> (+5.05%) ⬆️
libraries/standard/mqtt/src/mqtt_lightweight.c 97.44% <ø> (+2.92%) ⬆️
libraries/standard/mqtt/src/mqtt_state.c 98.46% <ø> (+2.52%) ⬆️
libraries/standard/http/src/http_client.c 98.53% <81.48%> (+11.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54090fb...b6d5b07. Read the comment docs.

@aggarw13 aggarw13 merged commit 234de33 into aws:development Aug 12, 2020
@aggarw13 aggarw13 deleted the hygiene/fix-unused-param-var-warnings-in-unit-test branch August 12, 2020 21:27
yourslab pushed a commit to yourslab/aws-iot-device-sdk-embedded-C that referenced this pull request Aug 17, 2020
leegeth pushed a commit to leegeth/aws-iot-device-sdk-embedded-C that referenced this pull request Aug 27, 2020
leegeth pushed a commit to leegeth/aws-iot-device-sdk-embedded-C that referenced this pull request Aug 28, 2020
leegeth pushed a commit to leegeth/aws-iot-device-sdk-embedded-C that referenced this pull request Aug 31, 2020
leegeth pushed a commit to leegeth/aws-iot-device-sdk-embedded-C that referenced this pull request Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants