Skip to content

[PR from CLI tool] Address -Wunused-variable and -Wunused-parameter warnings in lightweight tests #1117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2020
Merged

[PR from CLI tool] Address -Wunused-variable and -Wunused-parameter warnings in lightweight tests #1117

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions libraries/standard/mqtt/utest/mqtt_lightweight_utest.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,11 @@ static int32_t mockReceiveNoData( NetworkContext_t * pNetworkContext,
void * pBuffer,
size_t bytesToRecv )
{
/* Suppress unused parameter warning. */
( void ) pNetworkContext;
( void ) pBuffer;
( void ) bytesToRecv;

return 0;
}

Expand All @@ -192,6 +197,11 @@ static int32_t mockReceiveFailure( NetworkContext_t * pNetworkContext,
void * pBuffer,
size_t bytesToRecv )
{
/* Suppress unused parameter warning. */
( void ) pNetworkContext;
( void ) pBuffer;
( void ) bytesToRecv;

return -1;
}

Expand Down Expand Up @@ -736,7 +746,6 @@ void test_MQTT_SerializeSubscribe( void )
MQTTSubscribeInfo_t subscriptionList;
size_t subscriptionCount = 1;
size_t remainingLength = 0;
uint16_t packetIdentifier;
uint8_t buffer[ 25 + 2 * BUFFER_PADDING_LENGTH ];
size_t bufferSize = sizeof( buffer ) - 2 * BUFFER_PADDING_LENGTH;
size_t packetSize = bufferSize;
Expand Down Expand Up @@ -845,7 +854,6 @@ void test_MQTT_SerializeUnsubscribe( void )
MQTTSubscribeInfo_t subscriptionList;
size_t subscriptionCount = 1;
size_t remainingLength = 0;
uint16_t packetIdentifier;
uint8_t buffer[ 25 + 2 * BUFFER_PADDING_LENGTH ];
size_t bufferSize = sizeof( buffer ) - 2 * BUFFER_PADDING_LENGTH;
size_t packetSize = bufferSize;
Expand Down Expand Up @@ -1011,8 +1019,6 @@ void test_MQTT_SerializePublish( void )
{
MQTTPublishInfo_t publishInfo;
size_t remainingLength = 98;
uint16_t packetIdentifier;
uint8_t * pPacketIdentifierHigh;
uint8_t buffer[ 200 + 2 * BUFFER_PADDING_LENGTH ];
size_t bufferSize = sizeof( buffer ) - 2 * BUFFER_PADDING_LENGTH;
size_t packetSize = bufferSize;
Expand Down Expand Up @@ -1525,7 +1531,6 @@ void test_MQTT_DeserializePublish( void )

size_t remainingLength = 0;
uint16_t packetIdentifier;
uint8_t * pPacketIdentifierHigh;

fixedBuffer.pBuffer = buffer;
fixedBuffer.size = bufferSize;
Expand Down Expand Up @@ -1761,8 +1766,6 @@ void test_MQTT_SerializePublishHeader( void )
{
MQTTPublishInfo_t publishInfo;
size_t remainingLength = 0;
uint16_t packetIdentifier;
uint8_t * pPacketIdentifierHigh;
uint8_t buffer[ 200 + 2 * BUFFER_PADDING_LENGTH ];
uint8_t expectedPacket[ 200 ];
uint8_t * pIterator;
Expand Down Expand Up @@ -2324,7 +2327,6 @@ void test_MQTT_SerializeDisconnect_Invalid_Params()
void test_MQTT_SerializeDisconnect_Happy_Path()
{
MQTTStatus_t mqttStatus = MQTTSuccess;
size_t packetSize = 0;
MQTTFixedBuffer_t networkBuffer;

/* Fill structs to pass into methods to be tested. */
Expand Down