Skip to content

Conversation

justsmth
Copy link
Contributor

@justsmth justsmth commented Jul 21, 2025

Description of changes:

Implementation and documentation for:

  • SSL_client_hello_get1_extensions_present
  • SSL_client_hello_get_extension_order
  • SSL_client_hello_get0_legacy_version

Testing:

Added new tests for coverage.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@justsmth justsmth requested a review from a team as a code owner July 21, 2025 15:27
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2025

Codecov Report

❌ Patch coverage is 77.14286% with 32 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.69%. Comparing base (362e25e) to head (a6c2375).

Files with missing lines Patch % Lines
ssl/ssl_client_hello_test.cc 75.90% 19 Missing and 1 partial ⚠️
ssl/ssl_lib.cc 78.94% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2561      +/-   ##
==========================================
- Coverage   78.70%   78.69%   -0.01%     
==========================================
  Files         645      645              
  Lines      110882   111023     +141     
  Branches    15671    15685      +14     
==========================================
+ Hits        87265    87375     +110     
- Misses      22929    22958      +29     
- Partials      688      690       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@justsmth justsmth force-pushed the SSL_client_hello_get1_extensions_present branch from 3cde580 to 0ebf371 Compare July 22, 2025 13:35
@justsmth justsmth changed the title Impl SSL_client_hello_get1_extensions_present and SSL_client_hello_get_extension_order Impl SSL_client_hello_get1_extensions_present and friends Jul 22, 2025
@justsmth justsmth force-pushed the SSL_client_hello_get1_extensions_present branch from 4326849 to 9d485c1 Compare July 22, 2025 14:28
@justsmth justsmth force-pushed the SSL_client_hello_get1_extensions_present branch from 9d485c1 to 4e95542 Compare July 31, 2025 13:45
@justsmth justsmth force-pushed the SSL_client_hello_get1_extensions_present branch from 4e95542 to efb1554 Compare August 4, 2025 13:16
@justsmth justsmth force-pushed the SSL_client_hello_get1_extensions_present branch from efb1554 to 1282573 Compare August 7, 2025 16:42
@justsmth justsmth force-pushed the SSL_client_hello_get1_extensions_present branch from 1282573 to 9363370 Compare August 8, 2025 15:23
@justsmth justsmth requested a review from smittals2 August 8, 2025 17:25
smittals2
smittals2 previously approved these changes Aug 8, 2025
@justsmth justsmth force-pushed the SSL_client_hello_get1_extensions_present branch from 9363370 to a6c2375 Compare August 11, 2025 11:23
@justsmth justsmth merged commit 7c9a1f0 into aws:main Aug 11, 2025
130 of 136 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants